Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6846 - Added event to track start search button press #6931

Merged
merged 2 commits into from
Jul 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Client/Frontend/Browser/TabToolbar.swift
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ open class TabToolbarHelper: NSObject {
if loading {
toolbar.tabToolbarDelegate?.tabToolbarDidPressStop(toolbar, button: toolbar.stopReloadButton)
} else if isSearch {
UnifiedTelemetry.recordEvent(category: .action, method: .tap, object: .startSearchButton)
toolbar.tabToolbarDelegate?.tabToolbarDidPressSearch(toolbar, button: toolbar.stopReloadButton)
} else {
toolbar.tabToolbarDelegate?.tabToolbarDidPressReload(toolbar, button: toolbar.stopReloadButton)
Expand Down
1 change: 1 addition & 0 deletions Client/Telemetry/UnifiedTelemetry.swift
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ extension UnifiedTelemetry {
case dismissedOnboardingEmailLogin = "dismissed-onboarding-email-login"
case dismissedOnboardingSignUp = "dismissed-onboarding-sign-up"
case privateBrowsingButton = "private-browsing-button"
case startSearchButton = "start-search-button"
case removeUnVerifiedAccountButton = "remove-unverified-account-button"
case tabSearch = "tab-search"
case tabToolbar = "tab-toolbar"
Expand Down
7 changes: 7 additions & 0 deletions Docs/telemetry.md
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,13 @@ The event ping contains a list of events ([see event format on readthedocs.io](h
| Tab view button is pressed | action | press | tab-toolbar | tab-view | -n/a- |


### Tab Tray

| Event | category | method | object | value | extras |
|---------------------------------------------------------------------|----------|-----------|---------|------------------|---------------------------------------------------|
| Allow user to search or add url from tab tray search button | action | tap | start-search-button | -n/a- | -n/a- |


## Limits

* An event ping will not be sent until at least 3 events are recorded
Expand Down