-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #6816: update sync telemetry message format #6914
fix #6816: update sync telemetry message format #6914
Conversation
I am asking in https://bugzilla.mozilla.org/show_bug.cgi?id=1642386 if there is more we can do to validate this change. |
I tried it as well and got the same 200 OK response for quick login.
|
I think that unless the message is seriously malformed, it will respond with that, but it isn't doing validation until the later ingestion process runs. |
I mean even with the following got 200 so I am not sure what data will make it fail 🤷♂️
|
I agree, it just confirms it got a JSON payload, but it doesn't verify at that step. |
The backend team said the message looked good, yay! |
* main: [String Update] - Updated string formatting at various places in the app (#6919) Refactor Today widget to MVVM architecture : viewModel and model files added (#6864) fix #6816: update sync telemetry message format (#6914) [String Update] #6893: Added accessibility string for New Tab Button UI (#6910)
* main: Fix #6846 - Added event to track start search button press (#6931) Bugzilla 1649159: RTL char bug in downloaded file name (#6942) [String Update] - Updated string formatting at various places in the app (#6919) Refactor Today widget to MVVM architecture : viewModel and model files added (#6864) fix #6816: update sync telemetry message format (#6914) [String Update] #6893: Added accessibility string for New Tab Button UI (#6910)
I am not sure how to validate this, the message looks correct in the logs (see that now 'outgoing' key has an array value), and the server responds with a 200 OK