-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Today widget to MVVM architecture : viewModel and model files added #6864
Merged
noorhashem
merged 9 commits into
mozilla-mobile:main
from
noorhashem:noorhashem/today-widget-mvvm
Jul 7, 2020
Merged
Refactor Today widget to MVVM architecture : viewModel and model files added #6864
noorhashem
merged 9 commits into
mozilla-mobile:main
from
noorhashem:noorhashem/today-widget-mvvm
Jul 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbhasin2
reviewed
Jul 2, 2020
nbhasin2
reviewed
Jul 2, 2020
nbhasin2
reviewed
Jul 2, 2020
nbhasin2
reviewed
Jul 2, 2020
nbhasin2
reviewed
Jul 2, 2020
nbhasin2
reviewed
Jul 2, 2020
nbhasin2
reviewed
Jul 2, 2020
nbhasin2
reviewed
Jul 2, 2020
nbhasin2
reviewed
Jul 2, 2020
nbhasin2
reviewed
Jul 2, 2020
nbhasin2
reviewed
Jul 2, 2020
nbhasin2
reviewed
Jul 2, 2020
nbhasin2
reviewed
Jul 6, 2020
nbhasin2
reviewed
Jul 6, 2020
nbhasin2
reviewed
Jul 6, 2020
nbhasin2
approved these changes
Jul 6, 2020
noorhashem
force-pushed
the
noorhashem/today-widget-mvvm
branch
from
July 7, 2020 16:40
fb7e122
to
c49c8f8
Compare
This reverts commit 092343a.
noorhashem
force-pushed
the
noorhashem/today-widget-mvvm
branch
from
July 7, 2020 16:52
c49c8f8
to
30001b4
Compare
vphong
added a commit
that referenced
this pull request
Jul 8, 2020
* main: [String Update] - Updated string formatting at various places in the app (#6919) Refactor Today widget to MVVM architecture : viewModel and model files added (#6864) fix #6816: update sync telemetry message format (#6914) [String Update] #6893: Added accessibility string for New Tab Button UI (#6910)
vphong
added a commit
that referenced
this pull request
Jul 10, 2020
* main: Fix #6846 - Added event to track start search button press (#6931) Bugzilla 1649159: RTL char bug in downloaded file name (#6942) [String Update] - Updated string formatting at various places in the app (#6919) Refactor Today widget to MVVM architecture : viewModel and model files added (#6864) fix #6816: update sync telemetry message format (#6914) [String Update] #6893: Added accessibility string for New Tab Button UI (#6910)
dnarcese
pushed a commit
to dnarcese/firefox-ios
that referenced
this pull request
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TodayWidgetAppearanceDelegate
protocol for communication.ImageButton
andButtonWithSubtitle
classes in separate files