Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Today widget to MVVM architecture : viewModel and model files added #6864

Merged
merged 9 commits into from
Jul 7, 2020
Merged

Refactor Today widget to MVVM architecture : viewModel and model files added #6864

merged 9 commits into from
Jul 7, 2020

Conversation

noorhashem
Copy link
Contributor

  • added ViewModel File
  • added Model File
  • added TodayWidgetAppearanceDelegate protocol for communication.
  • Separated UX parameters in a separate file
  • Separated ImageButton and ButtonWithSubtitle classes in separate files
  • added accessiblity hints

@nbhasin2 nbhasin2 changed the base branch from master to main June 29, 2020 19:18
@noorhashem noorhashem force-pushed the noorhashem/today-widget-mvvm branch from fb7e122 to c49c8f8 Compare July 7, 2020 16:40
@noorhashem noorhashem force-pushed the noorhashem/today-widget-mvvm branch from c49c8f8 to 30001b4 Compare July 7, 2020 16:52
@noorhashem noorhashem merged commit bd6a427 into mozilla-mobile:main Jul 7, 2020
vphong added a commit that referenced this pull request Jul 8, 2020
@vphong
Merge branch 'main' into vphong/breachalerts-ui
7435ffb 
* main:
  [String Update] - Updated string formatting at various places in the app (#6919)
  Refactor Today widget to MVVM architecture : viewModel and model files added (#6864)
  fix #6816: update sync telemetry message format (#6914)
  [String Update] #6893: Added accessibility string for New Tab Button UI (#6910)
vphong added a commit that referenced this pull request Jul 9, 2020
@vphong
Merge branch 'main' into vphong/loginslist-tests
3a50252 
* main:
  Bugzilla 1649159: RTL char bug in downloaded file name (#6942)
  [String Update] - Updated string formatting at various places in the app (#6919)
  Refactor Today widget to MVVM architecture : viewModel and model files added (#6864)
vphong added a commit that referenced this pull request Jul 10, 2020
@vphong
Merge branch 'main' into vphong/breachalerts
ed401b3 
* main:
  Fix #6846 - Added event to track start search button press (#6931)
  Bugzilla 1649159: RTL char bug in downloaded file name (#6942)
  [String Update] - Updated string formatting at various places in the app (#6919)
  Refactor Today widget to MVVM architecture : viewModel and model files added (#6864)
  fix #6816: update sync telemetry message format (#6914)
  [String Update] #6893: Added accessibility string for New Tab Button UI (#6910)
@dnarcese dnarcese linked an issue Jul 14, 2020 that may be closed by this pull request
FXIOS-12 ⁃ [Today Widget] Refactor code #6709
Closed
dnarcese pushed a commit to dnarcese/firefox-ios that referenced this pull request Jul 14, 2020
@noorhashem @dnarcese
Refactor Today widget to MVVM architecture : viewModel and model file…
74091a2 
…s added (mozilla-mobile#6864)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbhasin2 nbhasin2 nbhasin2 approved these changes

@dnarcese dnarcese Awaiting requested review from dnarcese

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FXIOS-12 ⁃ [Today Widget] Refactor code
2 participants
@noorhashem @nbhasin2