Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FXIOS-456 ⁃ Logins database corrupted #6626

Closed
garvankeeley opened this issue May 19, 2020 · 1 comment
Closed

FXIOS-456 ⁃ Logins database corrupted #6626

garvankeeley opened this issue May 19, 2020 · 1 comment
Assignees
@garvankeeley
Labels
3 Story size Bug 🐞 This is a bug with existing functionality not behaving as expected P1 Issues that need to be completed for the current release QA Verified Issue verified by QA

Comments

@garvankeeley
Copy link
Contributor

garvankeeley commented May 19, 2020 •
edited by data-sync-user
Loading

We are seeing high volume of problems opening the rust logins DB
https://sentry-fm.prod.mozaws.net/mozilla/firefox-ios-v250/issues/274932/?query=is%3Aunresolved%20rust

Unspecified or other error when opening Rust Logins database

This is happening to 20-30 users (based on ID counts in Sentry), but it happens every time they use the app.

No STR, just reports. We need to be deleting the db and re-creating it for these users, as the DB is useless at that point anyway, being non-openable.
We have code that is supposed to handle this case (i.e. can't open DB so delete and recreate), which is not working for this situation.

It is likely related to salt extraction, where we had to externalize the DB salt (in order to have an unencrypted file header on the sql file that the OS can identify as an sql file).

┆Issue is synchronized with this Jira Task
@garvankeeley garvankeeley added the Bug 🐞 This is a bug with existing functionality not behaving as expected label May 19, 2020
@garvankeeley garvankeeley added 1 Story size P1 Issues that need to be completed for the current release and removed 1 Story size labels May 19, 2020
@athomasmoz athomasmoz added the 3 Story size label Jun 30, 2020
@garvankeeley garvankeeley self-assigned this Jul 10, 2020
garvankeeley added a commit to garvankeeley/firefox-ios that referenced this issue Jul 10, 2020
@garvankeeley
Fix mozilla-mobile#6626: re-create the logins db on failure to open
7858502
garvankeeley added a commit to garvankeeley/firefox-ios that referenced this issue Jul 10, 2020
@garvankeeley
Fix mozilla-mobile#6626: re-create the logins db on failure to open
e9d4f62
dnarcese pushed a commit to dnarcese/firefox-ios that referenced this issue Jul 14, 2020
@garvankeeley @dnarcese
Fix mozilla-mobile#6626: re-create the logins db on failure to open (m…
ccf20da 
…ozilla-mobile#6952)
@csuciu
Copy link

csuciu commented Jul 16, 2020

We tested all the Logins related functionalities and found no issues. Verifying as fixed on master 340e7b5.

@csuciu csuciu added the QA Verified Issue verified by QA label Jul 16, 2020
vphong added a commit that referenced this issue Jul 16, 2020
@vphong
Merge branch 'main' into vphong/breachalerts
eda4a55 
* main:
  Fix #6893 - Added new tab open button for landscape UI (#6947)
  Tint the default favicon white when in dark mode (#6873)
  Update release_checklist_template.md (#6970)
  Bug 1644846 - Migrate legacy telemetry to Glean (#6912)
  Create new_issues_to_project.yml
  Fix #6626: re-create the logins db on failure to open (#6952)
  Wrap long text in ETP message in action sheet popup (#6869)
  For #6495 - XCUITest sync int disconnect and connect same account to … (#6913)
  Bug 1595808 - Update decision image. r=tomprince (#6954)
  Removed LP Setup in hidden menu that got added twice (#6951)
vphong added a commit that referenced this issue Jul 16, 2020
@vphong
Merge branch 'vphong/breachalerts' into vphong/breachalerts-assets
6e462e7 
* vphong/breachalerts:
  Fix #6948 - Crash after rearranged folder and pressing save button (#6980)
  Incorporate BreachAlertsManager in to LoginsListViewController (#6934)
  Fix #6893 - Added new tab open button for landscape UI (#6947)
  Tint the default favicon white when in dark mode (#6873)
  Update release_checklist_template.md (#6970)
  Bug 1644846 - Migrate legacy telemetry to Glean (#6912)
  Create new_issues_to_project.yml
  Fix #6626: re-create the logins db on failure to open (#6952)
  Wrap long text in ETP message in action sheet popup (#6869)
  For #6495 - XCUITest sync int disconnect and connect same account to … (#6913)
  Bug 1595808 - Update decision image. r=tomprince (#6954)
  Removed LP Setup in hidden menu that got added twice (#6951)
@data-sync-user data-sync-user changed the title Logins database corrupted FXIOS-456 ⁃ Logins database corrupted Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garvankeeley garvankeeley

Labels
3 Story size Bug 🐞 This is a bug with existing functionality not behaving as expected P1 Issues that need to be completed for the current release QA Verified Issue verified by QA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@csuciu @garvankeeley @athomasmoz