reload table after breaches are loaded to update UI

Client/Frontend/Login Management/BreachAlertsManager.swift

@@ -57,7 +57,7 @@ final public class BreachAlertsManager {
     ///    - Parameters:
     ///         - logins: a list of logins to compare breaches to
     ///    - Returns:
-    ///         - an array of IndexPaths of breaches in the original list.
+    ///         - an array of LoginRecords of breaches in the original list.
     func findUserBreaches(_ logins: [LoginRecord]) -> Maybe<[LoginRecord]> {
         var result: [LoginRecord] = []
 
@@ -71,9 +71,7 @@ final public class BreachAlertsManager {
         for breach in self.breaches {
             if let potentialBreaches = loginsDictionary[breach.domain] {
                 for item in potentialBreaches {
-                    // date check
-                    let pwLastChanged = TimeInterval(item.timePasswordChanged*1000)
-
+                    let pwLastChanged = TimeInterval(item.timePasswordChanged/1000)
                     let dateFormatter = DateFormatter()
                     dateFormatter.dateFormat = "yyyy-MM-dd"
                     if let breachDate = dateFormatter.date(from: breach.breachDate)?.timeIntervalSince1970, pwLastChanged < breachDate {

Client/Frontend/Login Management/LoginDataSource.swift

@@ -42,6 +42,10 @@ class LoginDataSource: NSObject, UITableViewDataSource {
     @objc func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
         let cell = ThemedTableViewCell(style: .subtitle, reuseIdentifier: CellReuseIdentifier)
 
+        // Need to override the default background multi-select color to support theming
+        cell.multipleSelectionBackgroundView = UIView()
+        cell.applyTheme()
+
         if indexPath.section == LoginsSettingsSection {
             let hideSettings = viewModel.searchController?.isActive ?? false || tableView.isEditing
             let setting = indexPath.row == 0 ? boolSettings.0 : boolSettings.1
@@ -72,9 +76,6 @@ class LoginDataSource: NSObject, UITableViewDataSource {
                 }
             }
         }
-        // Need to override the default background multi-select color to support theming
-        cell.multipleSelectionBackgroundView = UIView()
-        cell.applyTheme()
         return cell
     }
 }

Client/Frontend/Login Management/LoginListViewController.swift

@@ -266,7 +266,11 @@ private extension LoginListViewController {
 
     func loadLogins(_ query: String? = nil) {
         loadingView.isHidden = false
-        viewModel.loadLogins(query, loginDataSource: self.loginDataSource)
+        viewModel.loadLogins(query, loginDataSource: self.loginDataSource)?.upon { _ in
+            DispatchQueue.main.async {
+                self.tableView.reloadData()
+            }
+        }
     }
 
     @objc func beginEditing() {

Client/Frontend/Login Management/LoginListViewModel.swift

@@ -33,7 +33,7 @@ final class LoginListViewModel {
         self.searchController = searchController
     }
 
-    func loadLogins(_ query: String? = nil, loginDataSource: LoginDataSource) {
+    func loadLogins(_ query: String? = nil, loginDataSource: LoginDataSource) -> Deferred<Maybe<[LoginRecord]>>? {
         // Fill in an in-flight query and re-query
         activeLoginQuery?.fillIfUnfilled(Maybe(success: []))
         activeLoginQuery = queryLogins(query ?? "")
@@ -44,6 +44,7 @@ final class LoginListViewModel {
             self.userBreaches = self.breachAlertsManager.findUserBreaches(logins).successValue
         }
         activeLoginQuery! >>== self.setLogins
+        return activeLoginQuery
     }
 
     /// Searches SQLite database for logins that match query.

ClientTests/BreachAlertsTests.swift

@@ -28,10 +28,10 @@ class MockBreachAlertsClient: BreachAlertsClientProtocol {
 class BreachAlertsTests: XCTestCase {
     var breachAlertsManager: BreachAlertsManager!
     let unbreachedLogin = [
-        LoginRecord(fromJSONDict: ["hostname" : "http://unbreached.com", "timePasswordChanged": 1590784648189])
+        LoginRecord(fromJSONDict: ["hostname" : "http://unbreached.com", "timePasswordChanged": 1594411049000])
     ]
     let breachedLogin = [
-        LoginRecord(fromJSONDict: ["hostname" : "http://breached.com", "timePasswordChanged": 1])
+        LoginRecord(fromJSONDict: ["hostname" : "http://breached.com", "timePasswordChanged": 46800000])
    ]
     override func setUp() {
         self.breachAlertsManager = BreachAlertsManager(MockBreachAlertsClient())