Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: terminal tabs widget #122242

Closed
3 tasks done
meganrogge opened this issue Apr 26, 2021 · 0 comments
Closed
3 tasks done

Test: terminal tabs widget #122242

meganrogge opened this issue Apr 26, 2021 · 0 comments

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Apr 26, 2021

Refs #120241

Complexity: 5

Authors: @Tyriar, @meganrogge

Create Issue


Note that testing terminal statuses specifically will be done in #122241

Verify that you can:

  • kill & split terminals using both the inline action buttons (on hover) and the context menu
  • rename and change the icon for an instance using the context menu
  • keybindings surfaced in the tabs context menu work as expected
  • change the location of the tabs with terminal.integrated.tabs.location or by right clicking an empty area in the tabs view and selecting the Move Tabs action in the context menu
    • navigate the tabs with the arrow keys after this, pressing enter to focus the terminal instance associated with that tab
  • double click the empty area to create a new terminal
  • show or hide the tabs view by changing the setting terminal.integrated.tabs.enabled or right clicking an empty area in the tabs view and selecting the Hide Tabs action
  • double click the sash to toggle between a minimized view and one which displays the text with limited extra width
  • focus the tabs view with the command workbench.action.terminal.focusTabsView or by using the associated keybinding
  • use the + and v buttons to create new terminals (also try splitting via the submenu action), configure terminal settings, or select the default profile
  • multi select tabs using ctrl/command and clicking
    • see options to kill and split enabled, change icon and rename disabled
  • double click to focus the associated terminal instance
  • see the "Tasks" description next to the terminal's title
  • toggle between seeing the single inline tab and the multiple-tabs view depending on how many terminals there are or whether the tabs are in the narrow view (driven by terminal.integrated.tabs settings)
  • use the new keybindings to navigate terminal tabs and focus the tabs widget (check the keybindings editor)

Other more exploratory items:

  • experiment with other settings under the terminal.integrated.tabs namespace
  • ensure tabs display correctly, an edge case to watch out for in particular here is when the panel is displayed (after a reload or not)
@meganrogge meganrogge added this to the April 2021 milestone Apr 26, 2021
@ghost ghost assigned isidorn, eamodio and mjbvz Apr 27, 2021
@isidorn isidorn removed their assignment Apr 27, 2021
@RMacfarlane RMacfarlane assigned RMacfarlane and unassigned eamodio Apr 27, 2021
@mjbvz mjbvz assigned eamodio and unassigned RMacfarlane and mjbvz Apr 27, 2021
@eamodio eamodio assigned RMacfarlane and unassigned eamodio Apr 28, 2021
@RMacfarlane RMacfarlane removed their assignment Apr 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants