Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split terminal or delete terminal should keep focus on the tab list #122334

Closed
isidorn opened this issue Apr 27, 2021 · 3 comments · Fixed by #122461
Closed

Split terminal or delete terminal should keep focus on the tab list #122334

isidorn opened this issue Apr 27, 2021 · 3 comments · Fixed by #122461
Assignees
@Tyriar @meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-tabs verification-found Issue verification failed verified Verification succeeded
Milestone
April 2021

Comments

@isidorn
Copy link
Contributor

isidorn commented Apr 27, 2021

Testing #122242

Keyboard focus on to the terminal list. Using keyboard delete or split a terminal. Focus is now lost.
For inspiration checkout how the explorer focuses the neighbour item when an element gets deleted. I would expect the terminal tab list to also do the same thus keeping focus stable
@isidorn isidorn added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Apr 27, 2021
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-tabs labels Apr 27, 2021
@Tyriar Tyriar added this to the April 2021 milestone Apr 27, 2021
@Tyriar Tyriar closed this as completed in b26b993 Apr 27, 2021
@Tyriar
Copy link
Member

Tyriar commented Apr 27, 2021

Think I closed this off incorrectly.

@Tyriar Tyriar reopened this Apr 27, 2021
meganrogge added a commit that referenced this issue Apr 27, 2021
@meganrogge
fix #122334
b683e5a
@meganrogge meganrogge mentioned this issue Apr 27, 2021
Merged
@isidorn
Copy link
Contributor Author

isidorn commented Apr 29, 2021

Delete terminal nicely keeps focus, however split terminal does not.
Steps:

  1. Focus into terminal tab list
  2. Using keyboard focus onto the split terminal action
  3. Space -> terminal is split, focus is lost 🐛

@isidorn isidorn reopened this Apr 29, 2021
@isidorn isidorn added the verification-found Issue verification failed label Apr 29, 2021
@isidorn
Copy link
Contributor Author

isidorn commented Apr 30, 2021

This works great now -> verified

@isidorn isidorn added the verified Verification succeeded label Apr 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-tabs verification-found Issue verification failed verified Verification succeeded
Projects
None yet
Milestone
April 2021
Development

Successfully merging a pull request may close this issue.

Use a menu instead of hard coding actions in tabsWidget microsoft/vscode
4 participants
@isidorn @Tyriar @meganrogge and others