Terminal tab should surface split information in aria label

[isidorn]

Testing #122242

Have multiple terminal tabs open. In one tab have a couple of split terminals. Visually they look like they belong to a tree, however this information is not conveyed to the screen reader. Here are some ideas on how to improve this:

• Put aria-level = 2 for elements that are inside the tree. Currently all elements have an aria-level = 1. If you prefer to leave it like that then the role of the whole thing should be a list and not a tree
• Modify aria label of an element in case he is part of a split

[Tyriar]

We're converting this into a list next iteration #121745, I think we need to indicate to the screen reader that it's a split though. Not sure how the special characters are read out now.

[Tyriar]

@isidorn hmm, should we be surfacing the fact that it's a split terminal to the screen reader at all? I think it's purely a UI feature so it shouldn't make a difference if you can't see the UI?

[isidorn]

@Tyriar oh great that you moving to the list. You should have a correct role list then.
I would still convey the group number as part of the aria label, since we do the same for editors in editor groups. It is useful for users to know how things are grouped on the screen in case there are navigation actions like switch tab, or move focus inside a terminal tab. Just make sure that the group label is at the end of the list element aria label so it is easy to skip.

Special character is not read out now because it is not part of the aria label.

[Tyriar]

Good point 👍

[Tyriar]

Scoped this issue down, conversion to list will be handled in #121745

[isidorn]

I see the code changes which look good, however when I try this out the group is not applied to the aria label, it is the same as before.

I have a ZSH, one tab with one terminal, and another tabs with two terminals. And all their labels are just zsh

[meganrogge]

When I inspect a split terminal tab label, it has the correct aria label.

[isidorn]

Oh but you are setting the aria-label on the wrong HTML element label-name
You should use the List AccessibilityProvider so the aria-label is properly set on the monaco-list-row element. It has to be on that element, since that element has focus and that is what the Screen Reader will read.
So I think it should be fixed here
https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/terminal/browser/terminalTabsWidget.ts#L67