Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show tab list if only one terminal tab with multiple terminals #122348

Closed
isidorn opened this issue Apr 27, 2021 · 3 comments · Fixed by #124480
Closed

Do not show tab list if only one terminal tab with multiple terminals #122348

isidorn opened this issue Apr 27, 2021 · 3 comments · Fixed by #124480
Assignees
@Tyriar @meganrogge
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders on-testplan terminal General terminal issues that don't fall under another label terminal-tabs
Milestone
May 2021

Comments

@isidorn
Copy link
Contributor

isidorn commented Apr 27, 2021

Testing #122242

Currently you show the tab list if I have only one tab with multiple terminals.
I think this is wrong and by default we should only show the tab list if there are multiple terminal tabs.

Reason in the following setup space is particularly valuable

Screenshot 2021-04-27 at 16 00 49
@Tyriar
Copy link
Member

Tyriar commented Apr 27, 2021

I don't think we should do this as the tab contains important information that would be hidden for the non-active terminal if we went this directyion. For example if the terminal is disconnected, task status (next iteration), etc. If this is a common setup I think the narrow tab view would be ideal.

If more people point this out we could expand terminal.integrated.tabs.hideForSingle but I wouldn't want to change this default.

@Tyriar Tyriar closed this as completed Apr 27, 2021
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Apr 27, 2021
@isidorn
Copy link
Contributor Author

isidorn commented Apr 27, 2021

Makes sense to have this under a hideForSingle settings. Maybe a reason to have that setting name more general and make it a string and not boolean.

@Tyriar Tyriar reopened this Apr 27, 2021
@Tyriar Tyriar removed the *as-designed Described behavior is as designed label Apr 27, 2021
@Tyriar Tyriar added this to the April 2021 milestone Apr 27, 2021
@Tyriar Tyriar added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label terminal-tabs labels Apr 27, 2021
This was referenced Apr 27, 2021
Closed
Closed
@Tyriar
Copy link
Member

Tyriar commented Apr 28, 2021

Setting change part of this is moved to #122551

@Tyriar Tyriar modified the milestones: April 2021, Backlog Apr 28, 2021
@Tyriar Tyriar added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Apr 28, 2021
@nrayburn-tech nrayburn-tech mentioned this issue May 24, 2021
Merged
@Tyriar Tyriar modified the milestones: Backlog, May 2021 May 24, 2021
bpasero pushed a commit to bpasero/vscode that referenced this issue May 25, 2021
@nrayburn-cyber @bpasero
option to hide terminal tabs if there is only a single group
dc92e81 
fixes microsoft#122348
Ashray123 pushed a commit to Ashray123/vscode that referenced this issue May 25, 2021
@nrayburn-cyber @Ashray123
option to hide terminal tabs if there is only a single group
6d1d540 
fixes microsoft#122348
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders on-testplan terminal General terminal issues that don't fall under another label terminal-tabs
Projects
None yet
Milestone
May 2021
Development

Successfully merging a pull request may close this issue.

option to hide terminal tabs if there is only a single group
4 participants
@isidorn @Tyriar @meganrogge and others