Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tab setting hideForSingle to hideCondition to allow future extensibility #122551

Closed
Tyriar opened this issue Apr 28, 2021 · 2 comments
Closed

Rename tab setting hideForSingle to hideCondition to allow future extensibility #122551

Tyriar opened this issue Apr 28, 2021 · 2 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-tabs verified Verification succeeded
Milestone
April 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 28, 2021

Splitting out from #122348 for verification
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-tabs labels Apr 28, 2021
@Tyriar Tyriar added this to the April 2021 milestone Apr 28, 2021
@Tyriar Tyriar self-assigned this Apr 28, 2021
@Tyriar Tyriar mentioned this issue Apr 28, 2021
Closed
@Tyriar Tyriar closed this as completed in 36fe842 Apr 28, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Apr 29, 2021

Think I broke something here, this is what I see regardless of terminal.integrated.tabs.hideCondition value on today's insiders

image

@Tyriar Tyriar reopened this Apr 29, 2021
@meganrogge
Copy link
Contributor

You didn't break something I did. Fixed here

bdb2324

@roblourens roblourens added the verified Verification succeeded label Apr 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-tabs verified Verification succeeded
Projects
None yet
Milestone
April 2021
Development

No branches or pull requests
4 participants
@roblourens @Tyriar @meganrogge and others