Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom terminal icons not restored on window reload #122441

Closed
mjbvz opened this issue Apr 27, 2021 · 2 comments · Fixed by #123010
Closed

Custom terminal icons not restored on window reload #122441

mjbvz opened this issue Apr 27, 2021 · 2 comments · Fixed by #123010
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-tabs verified Verification succeeded
Milestone
May 2021

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 27, 2021

Testing #122242

  1. Change the icon of a terminal
  2. Reload window

Bug
The icon is not restored

Possibly a duplicate of #120508
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-tabs labels Apr 27, 2021
@meganrogge meganrogge added this to the April 2021 milestone Apr 27, 2021
@Tyriar
Copy link
Member

Tyriar commented Apr 28, 2021

This would need a distro change, let's push this.

@Tyriar Tyriar modified the milestones: April 2021, Backlog Apr 28, 2021
@Tyriar
Copy link
Member

Tyriar commented May 3, 2021

We don't do this for names either

@Tyriar Tyriar modified the milestones: Backlog, May 2021 May 3, 2021
@Tyriar Tyriar added the terminal General terminal issues that don't fall under another label label May 3, 2021
meganrogge added a commit that referenced this issue May 5, 2021
@meganrogge
fix #122441
4df0a67
@meganrogge meganrogge mentioned this issue May 5, 2021
Merged
@lramos15 lramos15 added the verified Verification succeeded label Jun 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-tabs verified Verification succeeded
Projects
None yet
Milestone
May 2021
Development

Successfully merging a pull request may close this issue.

Persist terminal tab icons and titles on window reload microsoft/vscode
5 participants
@Tyriar @lramos15 @mjbvz @meganrogge and others