Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal tab widget does not render keybindings on hover #122336

Closed
isidorn opened this issue Apr 27, 2021 · 2 comments
Closed

Terminal tab widget does not render keybindings on hover #122336

isidorn opened this issue Apr 27, 2021 · 2 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-tabs verified Verification succeeded
Milestone
April 2021

Comments

@isidorn
Copy link
Contributor

isidorn commented Apr 27, 2021

Testing #122242

Hover over the Split Terminal or the Delete Terminal icons. I can not see the keybinding rendered, even though I have something assigned.
To fix this you can use the keybindingService and ask for a keybinding label and append it to the title.

Screenshot 2021-04-27 at 15 18 00
Screenshot 2021-04-27 at 15 19 39
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-tabs labels Apr 27, 2021
@Tyriar Tyriar added this to the April 2021 milestone Apr 27, 2021
@Tyriar
Copy link
Member

Tyriar commented Apr 27, 2021

We use a separate command for split and kill, eg. kill has delete bound, not the standard .kill command keybinding if you have one. We could just redefine the default ctrl+shift+5 here, but it wouldn't pick up customizations unless you bound to .killInstance as well.

@isidorn
Copy link
Contributor Author

isidorn commented Apr 27, 2021

I think that's fair. Keybindings on hover are mostly for beginners to learn, not for people who already customised obscure commands.

@Tyriar Tyriar closed this as completed in 724172d Apr 27, 2021
@isidorn isidorn added the verified Verification succeeded label Apr 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-tabs verified Verification succeeded
Projects
None yet
Milestone
April 2021
Development

No branches or pull requests
4 participants
@isidorn @Tyriar @meganrogge and others