Terminal tabs April plan

[Tyriar]

Plan item capturing terminal tabs work for April (#10546)

Legend of annotations:

Mark	Description
🏃	work in progress
✋	blocked task
💪	stretch goal for this iteration
🔵	more investigation required to remove uncertainty

• Icons @Tyriar
  • APIs
    • Proposed ext API Add TerminalOptions.icon API to support tabs in terminal #120538
    • Profile schema
    • Terminal types contribution (js debug)
    • ITerminalService/ITerminalInstance API for tasks
      • Adopt in tasks
  • 💪 Should also show icons in select default profile/new with profile
  • 💪 Color support: this could just be #rrggbb in the profile Deferred: Support changing tab color #121738
  • Assets: Generic terminal (terminal), generic WSL, Ubuntu, Debian, task (tools), cmd, pwsh, tmux Icons for terminal tabs vscode-codicons#51
• Terminal status Create the terminal status concept #120583 @Tyriar
  • Internal status tracking: name, severity, information (they need to be able to show the same information/actions as the info widget)
  • Terminal instance API to set statuses
    • Issue to adopt in tasks
  • Icon + status widget
  • Assets: Running (play), failed (error), succeeded (check), bell, disconnected (debug-disconnect), warning, info
• Visual bell @Tyriar
  • Add event to xterm.js Support event when the bell goes off xtermjs/xterm.js#3014
  • Hook up to icon status
  • Experiment with shake animation Decorations have minimal icon support
• Split pane @meganrogge
  • Widget to hold tabs (list/tree widget?)
    • 🔵 UX: How do splits show? Tree widget?
    • Actions on terminals (split, rename, kill)
    • Setting to move to side
    • Double click in empty area to create new default terminal Tracked in Double click in empty area to create new default terminal #121933
    • Scrollable overflow
    • 💪 Drag and drop
    • Context menu
  • 🔵 UX: Think through how this works when the panel is on the side Tracked in Hide the terminal profiles dropdown. It wastes space in column mode #121572
  • Responsive: Resizing should be able to hide titles
• New terminal with dropdown button
  • Leverage the combined run button in editor?
• Dropdown
  • 🔵 UX: Include split icon? This wouldn't work in native mac menus
• Default keybindings for navigating terminal tabs Add default keybindings for switching terminals #119653

[Tyriar]

Notes from today's UX meeting:

• New split terminals from the dropdown
  • Have a split item in the menu that is a submenu to all profiles
  • Let's not have a split icon in the menu as we don't do that anywhere and isn't supported by mac menus
  • Support alt+click, might not be possible on mac
• How do splits show in the tabs view?
  • Everyone liked the tree idea
  • The tab names could be "Terminal (2)"
• How do tabs show when the panel is on the side?
  • Keep the dropdown as an option
  • Default to collapsed tabs on left?

[BerriJ]

Will this also enable us to draw a terminal into one "corner" of the editor area. Currently, it's only possible to choose between "left", "right" or "bottom" but every option covers 100% of the height/width of the editor area. It would be fantastic If one could draw the terminal into e.g., the bottom right corner, so you can have one editor opened with 100% height (left side) 1, editor open with 50% height (right-top), and the Terminal area with 50% height (right bottom).

Sorry if this feature request is misplaced here, or if it's already tracked elsewhere.

[Tyriar]

@BerriJ that's out of scope for this month's work, but we're planning on doing that later

[miguelsolorio]

Terminal icons have now been added to codicons via 0e7d161:

vscode/src/vs/base/common/codicons.ts

Lines 554 to 558 in d520e94

	export const terminalCmd = new Codicon('terminal-cmd', { fontCharacter: '\\ebc4' });
	export const terminalDebian = new Codicon('terminal-debian', { fontCharacter: '\\ebc5' });
	export const terminalLinux = new Codicon('terminal-linux', { fontCharacter: '\\ebc6' });
	export const terminalPowershell = new Codicon('terminal-powershell', { fontCharacter: '\\ebc7' });
	export const terminalTmux = new Codicon('terminal-tmux', { fontCharacter: '\\ebc8' });

[Tyriar]

[pixieaka]

@Tyriar You can also add these split options also to the list down there?

[Tyriar]

This list is a bit out of date, will probably close this issue soon in favor of individual issues.

[pixieaka]

@Tyriar Some problems in 633562d

[Tyriar]

@pixieaka I think the bottom one tracked in #122161 already, created #122187 for top. Thanks 🙂