Show an indicator if a terminal task tab is "running"

[eamodio]

It would be great to be able to tell the difference between terminal tasks that are actually running (e.g. watch task) vs ones that are done but just aren't closed.

[Tyriar]

This is the plan, was only tracking this in #120241 so can track individually here.

[Tyriar]

@alexr00 this will need some adoption in tasks which might be a bit tough for me. Basically you want to add/remove statuses via ITerminalInstance.add/remove. These statuses would ideally be constants so you don't keep building objects, though you can just pass them in as well. I think we want statuses for:

• Task running (play? loading~spin?)
• Task success (check?)
• Task failure (one or more problems or non-zero exit? error?)

Example:

vscode/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

Line 491 in e382db3

this._xterm.onBell(() => this.statusList.add({ id: TerminalStatus.Bell, severity: Severity.Warning, icon: Codicon.bell }, 3000));

Note that we cannot yet use icons for statuses but @meganrogge is looking into that, in the meantime a letter can be added here:

https://github.com/Microsoft/vscode/blob/db221b816d5614828ddca4a8ca686d33c8f377b7/src/vs/workbench/contrib/terminal/browser/terminalDecorationsProvider.ts#L64-L81

Info is probably the right severity for running/success, warning for error (so the disconnected status overrides it).

[Tyriar]

We're all pretty busy, pushing.

[Tyriar]

I've added the ability to attach hover actions to the statuses:

So tasks could have rerun, stop, etc.

[alexr00]

The statuses I've added so far:

• Task is running and active -> loading play, loading can't be animated right now.
• Task is running and inactive with no errors (like a watch task that is waiting for file changes) -> play
• Task is running and inactive with some errors -> error
• Task is not running and succeeded -> check
• Task is not running and had an error exit code or other errors -> error

[alexr00]

I'm not sure I like using the warning severity for errors though:

It seems like too much. @Tyriar would you consider just showing the severity color on the status icon?

[Tyriar]

@alexr00 I think that is part of using the decorations system as well, so right now we align with explorer, scm and tabs. Should it be using the error severity?

[alexr00]

Consistency makes sense to me.

@Tyriar warning seems fine because of what you said above:

Info is probably the right severity for running/success, warning for error (so the disconnected status overrides it).

[alexr00]

@Tyriar I think a style change is still needed, but I added the spin for tasks:

[alexr00]

Terminal specific fix: https://github.com/microsoft/vscode/pull/124823/files