Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support event when the bell goes off #3014

Closed
Tyriar opened this issue Jul 16, 2020 · 2 comments · Fixed by #3290
Closed

Support event when the bell goes off #3014

Tyriar opened this issue Jul 16, 2020 · 2 comments · Fixed by #3290
Labels
good first issue help wanted type/enhancement Features or improvements to existing features
Milestone
4.12.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 16, 2020

Electron has an API to play the shell bell https://www.electronjs.org/docs/api/shell#shellbeep

To support this with xterm.js we would need to allow bellSound to take a () => void:

xterm.js/typings/xterm.d.ts

Lines 47 to 50 in ab63b51

/**
* A data uri of the sound to use for the bell when `bellStyle = 'sound'`.
*/
bellSound?: string;

@Tyriar Tyriar added type/enhancement Features or improvements to existing features help wanted good first issue labels Jul 16, 2020
@Tyriar Tyriar mentioned this issue Jul 16, 2020
Closed
@bolariin
Copy link

bolariin commented Aug 2, 2020

I would like to work on this issue

@Tyriar
Copy link
Member Author

Tyriar commented Aug 3, 2020

@bolariin sounds good 👍

@QuiiBz QuiiBz mentioned this issue Sep 13, 2020
Closed
@Tyriar Tyriar mentioned this issue Mar 31, 2021
Closed
36 tasks
@Tyriar Tyriar added this to the 4.12.0 milestone Mar 31, 2021
@Tyriar Tyriar changed the title Support callback as bellSound Support event when the bell goes off Mar 31, 2021
bmf-ribeiro pushed a commit to bmf-ribeiro/xterm.js that referenced this issue Apr 3, 2021
Fix xtermjs#3014
7b7b7a3 
 - Add onBell event listener to allow embeders to hook into it
@bmf-ribeiro bmf-ribeiro mentioned this issue Apr 3, 2021
Merged
Tyriar added a commit that referenced this issue Apr 6, 2021
@Tyriar
Merge pull request #3290 from nikonso/feat/3014-add-onBell-event-list…
eedc314 
…ener

Fix #3014  - Add onBell event listener to allow embeders to hook into it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
4.12.0
Development

Successfully merging a pull request may close this issue.

Fix #3014 - Add onBell event listener to allow embeders to hook into it bmf-ribeiro/xterm.js
2 participants
@Tyriar @bolariin