Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminal tabs UI #120591

Merged
merged 52 commits into from
Apr 8, 2021
Merged

terminal tabs UI #120591

merged 52 commits into from
Apr 8, 2021

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Apr 5, 2021 •
edited
Loading

Part of #120241

@Tyriar Tyriar changed the title tabs Work in progress terminal tabs UI Apr 5, 2021
@Tyriar Tyriar assigned meganrogge and unassigned bpasero Apr 5, 2021
Tyriar
Tyriar requested changes Apr 7, 2021
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing on my phone so I couldn't look into some things myself 🙂

src/vs/workbench/contrib/terminal/browser/tabsView.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/tabsView.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalTabsWidget.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalTabsWidget.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/common/terminal.ts Show resolved Hide resolved
src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts Outdated Show resolved Hide resolved
@meganrogge meganrogge changed the title Work in progress terminal tabs UI terminal tabs UI Apr 8, 2021
@meganrogge meganrogge added this to the April 2021 milestone Apr 8, 2021
@Tyriar Tyriar mentioned this pull request Apr 8, 2021
Closed
@Tyriar
Copy link
Member

Tyriar commented Apr 8, 2021

Exception on right click:

Screen Shot 2021-04-08 at 5 44 32 AM

@Tyriar Tyriar merged commit 6062a54 into main Apr 8, 2021
@Tyriar Tyriar deleted the merogge/tabs2 branch April 8, 2021 12:48
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
April 2021
Development

Successfully merging this pull request may close these issues.
4 participants
@meganrogge @Tyriar @bpasero @joaomoreno