Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the terminal profiles dropdown. It wastes space in column mode #121572

Closed
gotofritz opened this issue Apr 18, 2021 · 11 comments
Closed

Hide the terminal profiles dropdown. It wastes space in column mode #121572

gotofritz opened this issue Apr 18, 2021 · 11 comments
Assignees
Labels
polish Cleanup and polish issue terminal General terminal issues that don't fall under another label terminal-tabs
Milestone

Comments

@gotofritz
Copy link

Since the latest Insider Release VS Code automatically displays a dropdown with the terminal profiles. If the Terminal is in column mode, that wastes almost half of the screen space. Please let us remove it.
I don't need terminal profiles. Never asked for it, will never use it.
Please don't ruin the UI for the sake of the few users who may need the feature. Thanks

@Taswen
Copy link

Taswen commented Apr 18, 2021

+1. Ugly and wasteful. Merge it in the existing UI or set up optional options.

@karlhorky
Copy link

@gotofritz can you provide a screenshot of the suboptimal organization of the UI (eg. in column mode, like you mention)?

@gotofritz
Copy link
Author

Sure, here it is

vscode-bug

@Taswen
Copy link

Taswen commented Apr 18, 2021

I found an option to turn it off.
image

@Tyriar
Copy link
Member

Tyriar commented Apr 18, 2021

This is tabs not profiles, which is the second most voted feature request in the whole project so there were many who did ask for it.

It is still a work in progress though, right now you can drag the sash to the right to get a collapsed view, but you can also turn off tabs all together to go back to the dropdown via that setting.

I'll keep this open until we improve the panel on the side mode though, the thinking is to show the narrow view by default to minimize the amount of space used.

@Tyriar Tyriar added terminal General terminal issues that don't fall under another label terminal-tabs polish Cleanup and polish issue labels Apr 18, 2021
@Tyriar Tyriar added this to the April 2021 milestone Apr 18, 2021
@gotofritz
Copy link
Author

gotofritz commented Apr 18, 2021

When you click on the "v" it says "Select profile ..." and there is no mention of 'tabs' anywhere.... 🤷
OK, fine, tabs then.

the second most voted feature request in the whole project

My understanding was that 'tabs' would replace the awkward pulldown menu next to '... / Debug Console / Terminal' and basically work the same as it does for files - in which case I'm also for it. But your execution does nothing of the sort, it adds a space-wasting menu... so now I have a menu that says 'bash' above the terminal and another one that also says 'bash' on the left of it .... aaaargghh ....

the thinking is to show the narrow view by default

But why? Why waste screen estate like that for a column that has useful information for 10% of its height and the rest is wasted? Have you considered instead a second horizontal toolbar, below the one with 'problems / output / ... / terminal console' with your tabs? That would make the best use of the screen space (many of us use laptops!) and would fit in with the existing way tabs are shown for files

@gotofritz
Copy link
Author

Oh well done @Taswen.. I didn't realise this feature was called "Tabs", I was looking for "profiles" in the preferences! That solves my issue thanks!

@zzjin
Copy link

zzjin commented Apr 19, 2021

Maybe we can have settings to move those "Tabs" set to sub-top or bottom when in column mode?

@Tyriar
Copy link
Member

Tyriar commented Apr 19, 2021

so now I have a menu that says 'bash' above the terminal and another one that also says 'bash' on the left of it .... aaaargghh

The dropdown will go away when you have tabs showing as of today's insiders.

FYI this is the narrow view, you can resize the list to get it:

image

Maybe we can have settings to move those "Tabs" set to sub-top or bottom when in column mode?

It's a choice between the narrow view or the dropdown when the terminal is on the side, unless we invest a bunch of effort doing a horizontal design. We may end up doing that but probably not this month.

@Tyriar Tyriar self-assigned this Apr 21, 2021
@meganrogge
Copy link
Contributor

Now by default when you move the panel to the side, the tabs view is minimized. If you still don't want to see it, right click and select Hide Tabs

@gotofritz
Copy link
Author

Great, just got the update and it works very well. Thanks for you efforts @meganrogge @Tyriar and everyone else involved!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
polish Cleanup and polish issue terminal General terminal issues that don't fall under another label terminal-tabs
Projects
None yet
Development

No branches or pull requests

6 participants