Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default keybindings for switching terminals #119653

Closed
Tyriar opened this issue Mar 23, 2021 · 7 comments
Closed

Add default keybindings for switching terminals #119653

Tyriar opened this issue Mar 23, 2021 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal General terminal issues that don't fall under another label
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 23, 2021

I didn't end up making defaults for focusNext/focusPrevious and use ctrl+shift+j/k personally, but maybe it's time to make it act more like the editor tabs when the terminal is focused since it will be much clearer what terminal is focused when tabs come (#10546).

@Tyriar Tyriar added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label labels Mar 23, 2021
@Tyriar Tyriar added this to the April 2021 milestone Mar 23, 2021
@NotWearingPants
Copy link
Contributor

So you're suggesting Ctrl+Page Up/Down like normal tabs?
I like Alt+Left/Right.

@Tyriar
Copy link
Member Author

Tyriar commented Mar 23, 2021

Essentially yeah, also ctrl+1-9 and ctrl+(shift+)tab. Though I'm not sure I want to navigate my terminals via an MRU list like editors and I'm sure I'll have a hard time getting used to ctrl+tab not moving the editor 🤔

@Tyriar Tyriar mentioned this issue Mar 31, 2021
36 tasks
@pixieaka
Copy link

pixieaka commented Apr 9, 2021

@Tyriar In my opinion terminal key bindings can inherit from editor to unify user experience in all aspects.
For example ctrl + tab When terminal section focused to switch between opens terminals and ctrl + w for close current terminal.
This gonna be awesome because tabs got to terminal to unify editor experience, And this 'll be a plus to unify editor shortcuts as possible. This 'll effect the user at the end so he doesn't remember many shortcuts for editor and for terminal.

@Tyriar
Copy link
Member Author

Tyriar commented Apr 20, 2021

Editor shortcuts:

https://github.com/Microsoft/vscode/blob/601dec633b08a5184375b127d014967e90ae1954/src/vs/workbench/browser/parts/editor/editor.contribution.ts#L324-L325

@pixieaka I'm not sure we want to touch the ctrl+(shift+)tab shortcuts because some people like me use it to move focus from the terminal to the editor, plus we don't have the concept of MRU terminal navigation currently. For ctrl+w I'm hesitant to add because it's a shell shortcut.

@Tyriar Tyriar closed this as completed in f7b69ef Apr 20, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Apr 20, 2021

I went with:

  • Linux/Windows: Ctrl+Page Up/Down
  • macOS: Cmd+Shift+[/]

Mac also has cmd+alt+left/right to navigate tabs but that's already used to navigate split panes and this aligns with iterm.

@helloguille
Copy link

helloguille commented May 25, 2021

Hi, some feedback:

I'm on Version: 1.56.2 and the new "next pane" default shortcut is not working on Mac or it is so complicated that is impossible to remember and reach in some layouts like Spanish:

Screen Shot 2021-05-25 at 17 59 52

@helloguille
Copy link

helloguille commented May 25, 2021

Sorry if I'm overloading you- I feel like the following is much more natural as "next terminal" shortcut, now that they are shown vertically:

CMD+ALT+DOWN
CMD+ALT+UP

@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

6 participants
@helloguille @Tyriar @pixieaka @NotWearingPants @meganrogge and others