Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal tabs have odd rendering while going to/from icons only view #122431

Closed
mjbvz opened this issue Apr 27, 2021 · 4 comments
Closed

Terminal tabs have odd rendering while going to/from icons only view #122431

mjbvz opened this issue Apr 27, 2021 · 4 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders terminal-tabs verified Verification succeeded
Milestone
April 2021

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 27, 2021 •
edited
Loading

Testing #122242

  1. In the terminal tabs view with a few split terminal tabs
  2. Click and drag on the sash to collapse the tabs down so only icons are showing. Keep holding down on the sash

Bug
The icons aren't rendered and instead I see a ...

Screen Shot 2021-04-27 at 12 07 14 PM (2)

Another case:

  1. With only icons visible, click and drag to so that labels become visible. While holding the mouse to drag the sash, only the icons are shown:

Screen Shot 2021-04-27 at 12 07 11 PM (2)
@Tyriar
Copy link
Member

Tyriar commented Apr 27, 2021

I can't repro, any errors in console or special settings?

recording

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Apr 27, 2021
@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 27, 2021

Seems resolved in the insiders that just came out

@mjbvz mjbvz closed this as completed Apr 27, 2021
@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 27, 2021 •
edited
Loading

Never mind, still seeing this in 19cda32

It seems to happen when move the tabs left and then collapse the tab down once. After that, I start seeing the issue on Linux

@mjbvz mjbvz reopened this Apr 27, 2021
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-tabs and removed info-needed Issue requires more information from poster labels Apr 27, 2021
@meganrogge meganrogge added this to the April 2021 milestone Apr 27, 2021
@Tyriar Tyriar added the confirmed Issue has been confirmed by VS Code Team member label Apr 28, 2021
@Tyriar Tyriar closed this as completed in a9ad5d9 Apr 28, 2021
@Tyriar
Copy link
Member

Tyriar commented Apr 28, 2021

Repro:

  1. Open 2+ terminals
  2. Right click empty area and move to left
  3. Resize sash

@mjbvz mjbvz added the verified Verification succeeded label Apr 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders terminal-tabs verified Verification succeeded
Projects
None yet
Milestone
April 2021
Development

No branches or pull requests
4 participants
@Tyriar @mjbvz @meganrogge and others