Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/script/README.md #17305

Closed
wants to merge 31 commits into from
Closed

website/script/README.md #17305

wants to merge 31 commits into from

Conversation

reung37
Copy link
Contributor

@reung37 reung37 commented Oct 30, 2019

문서를 번역하였습니다. 리뷰 부탁드리겠습니다.

from #16552
/language ko

nasa9084 and others added 30 commits October 25, 2019 13:42
1. add a white space in line 367 between "###" and "版本兼容性".
* [WIP] Fix styling of tutorial pages

* additional cleanup of styles.css
* Removed multiple main tags from home page

Signed-off-by: chaitanyakaranam <[email protected]>

* Removed multiple occurances of main in case-studies page

Signed-off-by: chaitanyakaranam <[email protected]>

* Replaced css for main tag with .main-section class

Signed-off-by: ChaitanyaKaranam <[email protected]>

* Added main landmark role for all the pages

Signed-off-by: ChaitanyaKaranam <[email protected]>

* Force checks.

request-checks: true
* Translating "Organizing Cluster Access Using kubeconfig Files" to ID Localization

* Apply suggestions from code review

Co-Authored-By: Giri Kuncoro <[email protected]>
Add content based on Slack thread
https://kubernetes.slack.com/archives/C1TU9EB9S/p1570736679005700

Change -f to --force-with-lease
Simplified wording

Signed-off-by: Aimee Ukasick <[email protected]>
Alibaba Cloud supports serverless kubernetes, a Kubernetes-In-Kubernetes based solution.
* Update cluster-management.md

Fix link to version-skew upgrade doc

* Update cluster-management.md

fix pathing
In doc of kubeadm installation, there are commands which wont work
without sudo regarding to Ubuntu/Debian instruction. However, other
docs related to kubeadm under
content/en/docs/setup/production-environment have commands with sudo.

This commit fixes this inconsistency.
* Update network-plugins.md

* Update network-plugins.md
* 2019 Kubernetes Documentation Survey results

Incoporate reviewer feedback
Text and image
Add github location

Signed-off-by: Aimee Ukasick <[email protected]>

* Update and rename 2019-sig-docs-survey.md to 2019-10-29-2019-sig-docs-survey.md
@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Oct 30, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @reung37!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 30, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kbhawkey
You can assign the PR to them by writing /assign @kbhawkey in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language language/id Issues or PRs related to Indonesian language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 30, 2019
@netlify
Copy link

netlify bot commented Oct 30, 2019

Deploy preview for k8s-dev-ko ready!

Built with commit 9894e0f

https://deploy-preview-17305--k8s-dev-ko.netlify.com

@reung37
Copy link
Contributor Author

reung37 commented Oct 30, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kbhawkey
You can assign the PR to them by writing /assign @kbhawkey in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

("I signed it")

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 30, 2019
@reung37
Copy link
Contributor Author

reung37 commented Nov 1, 2019

/remove-language en
/remove-language id
/remove-language zh

@k8s-ci-robot k8s-ci-robot removed language/en Issues or PRs related to English language language/id Issues or PRs related to Indonesian language language/zh Issues or PRs related to Chinese language labels Nov 1, 2019
@gochist
Copy link
Member

gochist commented Nov 3, 2019

@reung37 I think scripts/README.md should be written in English which is the most used language by this community. I recommend you to create scripts/README-ko.md on the master branch if you want to translate it.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2019
@reung37 reung37 closed this Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.