Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Concepts section #17013

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Improve Concepts section #17013

merged 2 commits into from
Oct 28, 2019

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Oct 17, 2019

Signed-off-by: Alexey Pyltsyn [email protected]

@lex111
Improve Concepts section
eee5fd0 
Signed-off-by: Alexey Pyltsyn <[email protected]>
@k8s-ci-robot
Copy link
Contributor

Welcome @lex111!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 17, 2019
@netlify
Copy link

netlify bot commented Oct 17, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 9d94250

https://deploy-preview-17013--kubernetes-io-master-staging.netlify.com

@lex111
Copy link
Contributor Author

lex111 commented Oct 17, 2019

Signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 17, 2019
@lex111
Copy link
Contributor Author

lex111 commented Oct 19, 2019

Any news?

@zparnold
Copy link
Member

@lex111 Can you fix the merge conflicts?

@zparnold
Copy link
Member

Otherwise this seems like primarily formatting fixes.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019
@lex111
Copy link
Contributor Author

lex111 commented Oct 23, 2019

@zparnold done ✔️

sftim
sftim reviewed Oct 27, 2019
View reviewed changes
content/en/docs/concepts/containers/container-lifecycle-hooks.md
@@ -99,7 +99,7 @@ Here is some example output of events from running this command:

```
Events:
FirstSeen LastSeen Count From SubobjectPath Type Reason Message
FirstSeen LastSeen Count From SubObjectPath Type Reason Message
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct.

@tengqm
Copy link
Contributor

tengqm commented Oct 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit f120439 into kubernetes:master Oct 28, 2019
gaorong pushed a commit to gaorong/website that referenced this pull request Oct 30, 2019
@lex111 @gaorong
Improve Concepts section (kubernetes#17013)
592bb60 
Signed-off-by: Alexey Pyltsyn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@chenopis chenopis Awaiting requested review from chenopis

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lex111 @k8s-ci-robot @zparnold @tengqm @sftim