Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate poseidon firmament alternate scheduler #17043

Merged
merged 1 commit into from
Oct 29, 2019
Merged

translate poseidon firmament alternate scheduler #17043

merged 1 commit into from
Oct 29, 2019

Conversation

prabangkoro
Copy link
Contributor

translate poseidon firmament alternate scheduler

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 20, 2019
@prabangkoro
Copy link
Contributor Author

please kindly review
/assign @irvifa
/assign @girikuncoro
/assign @phanama

issue ticket: #15341

@netlify
Copy link

netlify bot commented Oct 20, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 6adb887

https://deploy-preview-17043--kubernetes-io-master-staging.netlify.com

girikuncoro
girikuncoro requested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, great work so far! 🎉 I've given several comments that are minor, mostly related to wordings and stylings. Please address them before getting this PR in. Thanks!

content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
@prabangkoro prabangkoro force-pushed the feature/translate-poseidon-firmament branch from 947f7d9 to 07fab52 Compare October 23, 2019 03:35
@prabangkoro
Copy link
Contributor Author

PR updated, please kindly review @girikuncoro

@phanama
Copy link
Contributor

phanama commented Oct 25, 2019

/assign @phanama

phanama
phanama suggested changes Oct 25, 2019
View reviewed changes
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated

Penjadwal _pod-by-pod_, seperti penjadwal bawaan Kubernetes, biasanya memproses satu Pod pada satu waktu. Penjadwal ini memiliki kelemahan penting berikut:

1. Penjadwal berkomitmen untuk penempatan Pod lebih awal dan membatasi pilihan untuk pod lain yang menunggu untuk ditempatkan.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Penjadwal berkomitmen untuk penempatan Pod lebih awal dan membatasi pilihan untuk pod lain yang menunggu untuk ditempatkan.
1. Penjadwal berkomitmen untuk penempatan Pod lebih awal dan membatasi pilihan untuk Pod lain yang menunggu untuk ditempatkan.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
content/id/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md Outdated Show resolved Hide resolved
phanama
phanama suggested changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@phanama phanama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the previous changes. Here's some reviews from me!

@girikuncoro girikuncoro mentioned this pull request Oct 27, 2019
Closed
45 tasks
@prabangkoro prabangkoro force-pushed the feature/translate-poseidon-firmament branch from 07fab52 to 6adb887 Compare October 28, 2019 12:00
@prabangkoro
Copy link
Contributor Author

thanks for the review @phanama !
I've update the PR ~
kindly review as well @girikuncoro

@girikuncoro
Copy link
Contributor

thanks for your contribution! 🎉
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit d527b60 into kubernetes:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanama phanama phanama requested changes

@girikuncoro girikuncoro girikuncoro requested changes

@irvifa irvifa Awaiting requested review from irvifa

Assignees

@girikuncoro girikuncoro

@irvifa irvifa

@phanama phanama

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prabangkoro @phanama @girikuncoro @k8s-ci-robot @irvifa