redirect to vSphere cloud provider docs in cloud providers page #16778
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
language/en
|
/assign @dvonthenen |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 99eac71 https://deploy-preview-16778--kubernetes-io-master-staging.netlify.com |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 104ff5b https://deploy-preview-16778--kubernetes-io-master-staging.netlify.com |
|
|
||
| ### Node Name | ||
| The in-tree vSphere cloud provider is recommended if you are running vSphere < 6.7u3. Quick start for the in-tree cloud provider can be found [here](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/k8s-vcp-on-vsphere-with-kubeadm.html). |
There was a problem hiding this comment.
| The in-tree vSphere cloud provider is recommended if you are running vSphere < 6.7u3. Quick start for the in-tree cloud provider can be found [here](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/k8s-vcp-on-vsphere-with-kubeadm.html). | |
| If you are running vSphere < 6.7u3, VMware recommend you use the in-tree vSphere cloud provider. See [Running a Kubernetes Cluster on vSphere with kubeadm](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/k8s-vcp-on-vsphere-with-kubeadm.html) for a quick start guide. |
|
|
||
| The VSphere cloud provider uses the detected hostname of the node (as determined by the kubelet) as the name of the Kubernetes Node object. | ||
| For all vSphere deployments on vSphere >= 6.7u3, the [external vSphere cloud provider](https://github.com/kubernetes/cloud-provider-vsphere) - along with the [vSphere CSI driver](https://github.com/kubernetes-sigs/vsphere-csi-driver) - is recommended. Quick start for the external cloud provider can be found [here](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/kubernetes-on-vsphere-with-kubeadm.html) |
There was a problem hiding this comment.
| For all vSphere deployments on vSphere >= 6.7u3, the [external vSphere cloud provider](https://github.com/kubernetes/cloud-provider-vsphere) - along with the [vSphere CSI driver](https://github.com/kubernetes-sigs/vsphere-csi-driver) - is recommended. Quick start for the external cloud provider can be found [here](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/kubernetes-on-vsphere-with-kubeadm.html) | |
| For all vSphere deployments on vSphere >= 6.7u3, VMware recommend the [external vSphere cloud provider](https://github.com/kubernetes/cloud-provider-vsphere), along with the [vSphere CSI driver](https://github.com/kubernetes-sigs/vsphere-csi-driver). See [Running a Kubernetes Cluster on vSphere with kubeadm](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/k8s-vcp-on-vsphere-with-kubeadm.html) for a quick start guide. |
|
|
||
| The `--hostname-override` parameter is ignored by the VSphere cloud provider. | ||
| For in-depth documentation on the vSphere cloud provider, visit the docs site at https://cloud-provider-vsphere.sigs.k8s.io/ |
|
|
||
| ### Node Name |
There was a problem hiding this comment.
As there are two options, consider using tabs.
|
Good feedback... plus, I learned about using tabs. 😀 |
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
lgtm
|
@sftim thanks for the feedback, comments addressed |
|
|
||
| {{< tabs name="vSphere cloud provider" >}} | ||
| {{% tab name="vSphere >= 6.7U3" %}} | ||
| For all vSphere deployments on vSphere >= 6.7U3, VMware recommends the [external vSphere cloud provider](https://github.com/kubernetes/cloud-provider-vsphere), along with the [vSphere CSI driver](https://github.com/kubernetes-sigs/vsphere-csi-driver). See [Deploying a Kubernetes Cluster on vSphere with CSI and CPI](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/kubernetes-on-vsphere-with-kubeadm.html) for a quick start guide. |
There was a problem hiding this comment.
would it make sense here to point to CAPV? could be a nice way to get started quickly with vSphere consuming the out-of-tree components mentioned here.
There was a problem hiding this comment.
There was a problem hiding this comment.
yes -- but I personally don't think we should be prescriptive to deployment solutions in the cloud provider docs.
|
/hold cancel Comments addressed, PTAL |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Thinking about this more, I'm not 100% comfortable with “VMWare recommends X”. It'd be more in line with the style guide (and the rest of the page) to write “use X” instead. |
|
I agree, I think "VMware recommends" is too prescriptive for kubernetes.io docs. I think just : 👍 ? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zparnold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Andrew Sy Kim <[email protected]>
|
@sftim updated wording per your suggestion, PTAL :) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Signed-off-by: Andrew Sy Kim [email protected]
The vSphere cloud provider has a docs site at https://cloud-provider-vsphere.sigs.k8s.io, we should redirect vSphere users there in the "Cloud Providers" page.