Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility updates - main landmark roles #17106

Merged
merged 5 commits into from
Oct 27, 2019
Merged

Accessibility updates - main landmark roles #17106

merged 5 commits into from
Oct 27, 2019

Conversation

ChaitanyaKaranam
Copy link
Contributor

This PR fixes below accessibility issues:

  1. The document should have only one main element.
    Multiple occurrences of main element are removed.
  2. main element is added to documents wherever applicable.
  3. The CSS for main element is replaced with class .main-section

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 22, 2019
@ChaitanyaKaranam
Copy link
Contributor Author

Fixes issue

@netlify
Copy link

netlify bot commented Oct 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit e179a35

https://deploy-preview-17106--kubernetes-io-master-staging.netlify.com

@ChaitanyaKaranam
Force checks.
28cc246 
request-checks: true
@netlify
Copy link

netlify bot commented Oct 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b7aaf09

https://deploy-preview-17106--kubernetes-io-master-staging.netlify.com

@netlify
Copy link

netlify bot commented Oct 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 28cc246

https://deploy-preview-17106--kubernetes-io-master-staging.netlify.com

@sftim
Copy link
Contributor

sftim commented Oct 23, 2019

Looks good at a glance. I'll try to make time to review this in more detail.

@zparnold
Copy link
Member

This also looks good to me. Pending @sftim this is approved.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019
@bradtopol
Copy link
Contributor

Assigning @sftim since its waiting his review
/assign @sftim

sftim
sftim approved these changes Oct 27, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6a4238a into kubernetes:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim approved these changes

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChaitanyaKaranam @sftim @zparnold @k8s-ci-robot @bradtopol