Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base64 --decode works across Linux and MacOS #17240

Merged
merged 1 commit into from
Oct 30, 2019
Merged

base64 --decode works across Linux and MacOS #17240

merged 1 commit into from
Oct 30, 2019

Conversation

drnic
Copy link
Contributor

@drnic drnic commented Oct 28, 2019

No description provided.

@k8s-ci-robot
Copy link
Contributor

Welcome @drnic!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 28, 2019
@netlify
Copy link

netlify bot commented Oct 28, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d053f16

https://deploy-preview-17240--kubernetes-io-master-staging.netlify.com

@drnic
Copy link
Contributor Author

drnic commented Oct 28, 2019

Generated docs are very neat. https://deploy-preview-17240--kubernetes-io-master-staging.netlify.com/docs/tasks/administer-cluster/access-cluster-api/#without-kubectl-proxy includes change.

@nasa9084
Copy link
Member

please create PRs for each language separately

@drnic
Copy link
Contributor Author

drnic commented Oct 28, 2019 •
edited
Loading

I can do that; though it is a confusing request - I’m not changing any language issues - rather fixing a coding example.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2019
@drnic
Copy link
Contributor Author

drnic commented Oct 28, 2019 •
edited
Loading

I've updated this PR/commit and removed the changes to non-EN language files.

Could someone please update the language tags on the PR?

sftim
sftim approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2019
@sftim
Copy link
Contributor

sftim commented Oct 28, 2019

/remove-language fr
/remove-language ja
(if Prow will let me)

@k8s-ci-robot k8s-ci-robot removed language/fr Issues or PRs related to French language language/ja Issues or PRs related to Japanese language labels Oct 28, 2019
@neolit123
Copy link
Member

/lgtm

@tengqm
Copy link
Contributor

tengqm commented Oct 30, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit cdc5900 into kubernetes:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim approved these changes

@nasa9084 nasa9084 Awaiting requested review from nasa9084

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

Assignees

@neolit123 neolit123

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@drnic @k8s-ci-robot @nasa9084 @sftim @neolit123 @tengqm