add @oke-py as sig-docs-ja reviewer #17182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasa9084
requested review from
makocchi-git,
zacharysarah,
oke-py,
MasayaAoyama and
inductor
k8s-ci-robot
added
do-not-merge/invalid-commit-message
nasa9084
force-pushed
the
update/sig-docs-ja/oke-py
branch
from
4260e66 to
5420487
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @jimangel |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 4260e66 https://deploy-preview-17182--kubernetes-io-master-staging.netlify.com |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 5420487 https://deploy-preview-17182--kubernetes-io-master-staging.netlify.com |
|
lgtm |
MasayaAoyama
approved these changes
Oct 25, 2019
|
I don't think I can comment on this one |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimangel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add @oke-py as a new member of sig-docs-ja reviewer