Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Indonesian translation for object-management page #16854

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Add Indonesian translation for object-management page #16854

merged 1 commit into from
Oct 30, 2019

Conversation

girikuncoro
Copy link
Contributor

This PR translates the object-management page from #15341 for Indonesian language

/language id
/cc @kubernetes/sig-docs-id-reviews

@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 12, 2019
@girikuncoro
Copy link
Contributor Author

/assign @irvifa

@netlify
Copy link

netlify bot commented Oct 12, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f31c7ba

https://deploy-preview-16854--kubernetes-io-master-staging.netlify.com

@girikuncoro girikuncoro mentioned this pull request Oct 12, 2019
Closed
45 tasks
danninov
danninov suggested changes Oct 13, 2019
View reviewed changes
Copy link
Contributor

@danninov danninov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some rewording for better clarity

content/id/docs/concepts/overview/working-with-objects/object-management.md Outdated
## Metode pengaturan

{{< warning >}}
Sebuah objek Kubernetes haruslah diatur dengan hanya menggunakan satu metode. Mengkombinasikan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sebuah objek Kubernetes hanya boleh diatur dengan menggunakan satu metode saja.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed here 4a23f4b

content/id/docs/concepts/overview/working-with-objects/object-management.md Outdated
Comment on lines 68 to 69
(_create_, _replace_, etc.), _flag-flag_ pilihan dan paling tidak satu nama berkas.
Berkas yang ditentukan haruslah berisikan definisi lengkap dari objek tersebut
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. dan minimal satu nama berkas. Berkas ini harus berisi definisi lengkap ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed here 4a23f4b

content/id/docs/concepts/overview/working-with-objects/object-management.md Outdated
{{< warning >}}
Perintah imperatif `replace` menggantikan spek yang sudah ada dengan spek yang baru,
membuang semua perubahan terhadap objek tersebut yang tidak didefinisikan pada berkas konfigurasi.
Metode ini sebaiknya tidak dilakukan dengan tipe sumber daya yang spek-nya diperbarui
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metode ini sebaiknya tidak dilakukan pada ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed here 4a23f4b

@girikuncoro girikuncoro requested a review from danninov October 13, 2019 13:39
@girikuncoro
Copy link
Contributor Author

@irvifa can you help approving/reviewing this

@irvifa
Copy link
Member

irvifa commented Oct 29, 2019

/lgtm
Can you please squash the commit first @girikuncoro ?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2019
@irvifa
Copy link
Member

irvifa commented Oct 29, 2019

/approve

Thank you @girikuncoro 🎉

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2019
@irvifa
Copy link
Member

irvifa commented Oct 30, 2019 •
edited
Loading

/lgtm
/approved

@irvifa
Copy link
Member

irvifa commented Oct 30, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit c324bfd into kubernetes:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvifa irvifa Awaiting requested review from irvifa

@danninov danninov Awaiting requested review from danninov

Assignees

@irvifa irvifa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@girikuncoro @irvifa @k8s-ci-robot @danninov