Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix styling of tutorial pages #17177

Merged
merged 2 commits into from
Oct 26, 2019
Merged

Fix styling of tutorial pages #17177

merged 2 commits into from
Oct 26, 2019

Conversation

kbhawkey
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 24, 2019
@kbhawkey kbhawkey mentioned this pull request Oct 24, 2019
Merged
@kbhawkey
Copy link
Contributor Author

/cc @BenHall

@k8s-ci-robot
Copy link
Contributor

@kbhawkey: GitHub didn't allow me to request PR reviews from the following users: BenHall.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @BenHall

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Oct 24, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 24ea690

https://deploy-preview-17177--kubernetes-io-master-staging.netlify.com

@kbhawkey
Copy link
Contributor Author

kbhawkey commented Oct 24, 2019 •
edited
Loading

@BenHall , if you have time, I would appreciate your input. Thanks!
The interactive tutorial pages also link to overrides.css, for example:
/docs/tutorials/kubernetes-basics/public/css/overrides.css. I intend to leave this file alone (setting the flyout-button var).

@kbhawkey
Copy link
Contributor Author

kbhawkey commented Oct 25, 2019 •
edited
Loading

Preview pages:
https://deploy-preview-17177--kubernetes-io-master-staging.netlify.com/docs/tutorials/kubernetes-basics/create-cluster/cluster-intro/

https://deploy-preview-17177--kubernetes-io-master-staging.netlify.com/docs/tutorials/kubernetes-basics/deploy-app/deploy-intro/

https://deploy-preview-17177--kubernetes-io-master-staging.netlify.com/docs/tutorials/kubernetes-basics/explore/explore-intro/

https://deploy-preview-17177--kubernetes-io-master-staging.netlify.com/docs/tutorials/kubernetes-basics/expose/expose-intro/

https://deploy-preview-17177--kubernetes-io-master-staging.netlify.com/docs/tutorials/kubernetes-basics/update/update-intro/

https://deploy-preview-17177--kubernetes-io-master-staging.netlify.com/docs/tutorials/kubernetes-basics/scale/scale-intro/

@kbhawkey kbhawkey force-pushed the testing-tutorial-styles branch from 28ed643 to 24ea690 Compare October 25, 2019 16:07
@kbhawkey kbhawkey changed the title [WIP] Fix styling of tutorial pages Fix styling of tutorial pages Oct 25, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2019
sftim
sftim approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

@BenHall
Copy link
Contributor

BenHall commented Oct 26, 2019

The changes look good to me. Thank you.

I believe overrides.css is what we hide the sidebar TOC on the Katacoda interactive pages so give the terminal more space. This should remain in place as it's only required on those pages.

@bradtopol
Copy link
Contributor

/assign

@bradtopol
Copy link
Contributor

So changes looked good to me and @sftim, and @BenHall is good with the changes so I think we are all set. Great job!!!!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit c26ea07 into kubernetes:master Oct 26, 2019
@kbhawkey kbhawkey deleted the testing-tutorial-styles branch July 30, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim approved these changes

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

Assignees

@bradtopol bradtopol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kbhawkey @k8s-ci-robot @BenHall @bradtopol @sftim