-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #15161 - Fix card alignments in kubernetes baiscs tutorial page. #17051
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit c12fdba https://deploy-preview-17051--kubernetes-io-master-staging.netlify.com |
/lgtm |
/assign @kbhawkey |
Hi @miteshskj .
|
Thanks for reviewing @kbhawkey Please review again. |
Hi @miteshskj. I reviewed the changes and preview again. |
For further information, see #17108. |
/hold cancel |
@miteshskj , I created a PR (#17177) to fix the styling of the tutorial pages. |
/lgtm |
Thanks! |
Thanks @kbhawkey ! Yes I reverted the blog file as the bootstrap css was not needed in index.html so didn't see the need to upgrade the version in blog. |
OK. If this information is in the commit message, would you remove the comment about updating the blog file? |
Commit message was updated, I have updated the PR description to remove the blog file info. |
@miteshskj , The English version of the page, for the multi-step graphics, looks okay now. |
Thank you @kbhawkey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bene2k1, daminisatya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #15161
The _index.html did not have stylesheet links causing incorrect layout. Included them for all languages which had _index.html files.