-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proto Any Tx migration #6213
Labels
Milestone
Comments
This was referenced May 13, 2020
15 tasks
This was referenced Jun 2, 2020
Merged
Merged
8 tasks
This was referenced Jun 15, 2020
This was referenced Jun 30, 2020
This was referenced Jul 2, 2020
9 tasks
9 tasks
8 tasks
9 tasks
9 tasks
This was referenced Jul 27, 2020
9 tasks
This was referenced Jul 30, 2020
This was referenced Aug 4, 2020
Merged
This was referenced Aug 5, 2020
This was referenced Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tracking issue for implementing ADR 020 updates from #6111 and discussed at length in #6078:
Critical Path
Tx
,SignDoc
, etc. typesPublicKey
encodingSIGN_MODE_DIRECT
SignDocRaw
andTxRaw
to a separate packagestart sequence and account numbers from one -- architecture concerns have been raised, so may need to be re-evaluatedwon't fix Propose ADR 027: Deterministic Protobuf Serialization #6979SIGN_MODE_LEGACY_AMINO_JSON
StdTx
to be used for signing from a protoTx
StdTx
JSON to a protoTx
withSIGN_MODE_LEGACY_AMINO_JSON
setx/auth/ante
tests to use the newclient.TxGenerator
(to finish Remove GetSignatures from SigVerifiableTx #6550)simapp/helpers.GenTx
should useTxGenerator
as a parameter ( see Implement SIGN_MODE_DIRECT #6216 )x/auth
commands to useTxGenerator
andSignatureV2
(some of these are partially done in Implement SIGN_MODE_DIRECT #6216 - see thex/auth/client
package):validate-signatures
sign
,multisign
andsign-batch
@sahith-naraharibroadcast
encode
/decode
x/genutil
to useTxGenerator
x/auth
encode
,decode
andbroadcast
REST endpoints - these MUST take amino jsonStdTx
and convert to proto behind the scenes - for backwards compatibilityencode
- takes an amino JSONStdTx
and returns protoTx
binarydecode
- take protoTx
binary and return amino JSONStdTx
broadcast
- take amino JSONStdTx
, broadcast proto binaryTx
StdTx
but use protobufTx
under the hood for simulationextension_options
and signing modesCleanup and Future Improvements
x/auth/types.TxBuilder
(in favor ofclient/tx.Factory
)address multisig handling and legacy amino addresses (Extensible address format #5694)StdTx
, etc. types fromcodec/
SigFeeMemoTx
from fix int overflow error for rand.Intn #5385StdTx
, etc. to ax/auth/tx/legacy
packageSIGN_MODE_TEXTUAL
The text was updated successfully, but these errors were encountered: