Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robert/move amino stdtx #7301

Merged
merged 6 commits into from
Sep 22, 2020
Merged

Robert/move amino stdtx #7301

merged 6 commits into from
Sep 22, 2020

Conversation

robert-zaremba
Copy link
Collaborator

@robert-zaremba robert-zaremba commented Sep 14, 2020

Description

Part of the Cleanup and Future Improvements for v.40 release (#6213)
Moving legacy structures and functions to a legacy package.

closes: #7255


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #7301 into master will increase coverage by 0.01%.
The diff coverage is 76.01%.

@@            Coverage Diff             @@
##           master    #7301      +/-   ##
==========================================
+ Coverage   55.81%   55.83%   +0.01%     
==========================================
  Files         584      586       +2     
  Lines       35855    35848       -7     
==========================================
  Hits        20014    20014              
+ Misses      13876    13871       -5     
+ Partials     1965     1963       -2     

Copy link
Contributor

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - few minor questions about interface assertions.

x/auth/ante/basic.go Show resolved Hide resolved
x/auth/ante/fee.go Show resolved Hide resolved
x/auth/legacy/legacytx/amino_signing.go Show resolved Hide resolved
x/auth/legacy/legacytx/stdtx_builder.go Show resolved Hide resolved
x/auth/types/stdsignmsg.go Outdated Show resolved Hide resolved
x/auth/types/stdsignmsg.go Outdated Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just two tiny nits.

I believe it's good to go once conflicts are merged.

x/auth/legacy/legacytx/stdtx_builder.go Outdated Show resolved Hide resolved
types/tx_msg.go Outdated Show resolved Hide resolved
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronc aaronc added A:automerge Automatically merge PR once all prerequisites pass. C:x/auth labels Sep 22, 2020
@mergify mergify bot merged commit f5afdd0 into master Sep 22, 2020
@mergify mergify bot deleted the robert/move-amino-stdtx branch September 22, 2020 14:35
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* x/auth: move amino StdTx... to a legacy package

* legacytx: move RegisterLegacyAminoCodec from init to tests/init

* merge fixes

Co-authored-by: Aaron Craelius <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move amino StdTx, etc. to a x/auth/tx/legacy package
5 participants