-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robert/move amino stdtx #7301
Robert/move amino stdtx #7301
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7301 +/- ##
==========================================
+ Coverage 55.81% 55.83% +0.01%
==========================================
Files 584 586 +2
Lines 35855 35848 -7
==========================================
Hits 20014 20014
+ Misses 13876 13871 -5
+ Partials 1965 1963 -2 |
d29dd55
to
e1b631e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK - few minor questions about interface assertions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just two tiny nits.
I believe it's good to go once conflicts are merged.
562a27e
to
cc5adf5
Compare
c4aca90
to
9ff7b92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* x/auth: move amino StdTx... to a legacy package * legacytx: move RegisterLegacyAminoCodec from init to tests/init * merge fixes Co-authored-by: Aaron Craelius <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Description
Part of the Cleanup and Future Improvements for v.40 release (#6213)
Moving legacy structures and functions to a legacy package.
closes: #7255
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes