Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move amino StdTx, etc. to a x/auth/tx/legacy package #7255

Closed
2 of 4 tasks
robert-zaremba opened this issue Sep 8, 2020 · 3 comments · Fixed by #7301
Closed
2 of 4 tasks

move amino StdTx, etc. to a x/auth/tx/legacy package #7255

robert-zaremba opened this issue Sep 8, 2020 · 3 comments · Fixed by #7301
Assignees
@robert-zaremba
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Encoding Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Milestone
v0.40 [Stargate]

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Sep 8, 2020 •
edited
Loading

Summary

Part of the Cleanup and Future Improvements for v.40 release (#6213)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba self-assigned this Sep 8, 2020
@robert-zaremba robert-zaremba added A:automerge Automatically merge PR once all prerequisites pass. Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. C:Encoding labels Sep 8, 2020
@robert-zaremba robert-zaremba added this to the v0.40 [Stargate] milestone Sep 8, 2020
@aaronc aaronc mentioned this issue Sep 8, 2020
Closed
27 tasks
@robert-zaremba
Copy link
Collaborator Author

@aaronc , should we move StdSignDoc, StdSignBytes and StdSignature as well?

@robert-zaremba
Copy link
Collaborator Author

looks like almost everything from /x/auth/types/stdtx.go should go.

@aaronc
Copy link
Member

aaronc commented Sep 9, 2020

Yes all that stuff should go together. StdFee as well.

@robert-zaremba robert-zaremba mentioned this issue Sep 14, 2020
Merged
9 tasks
@mergify mergify bot closed this as completed in #7301 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robert-zaremba robert-zaremba

Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Encoding Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
v0.40 [Stargate]
Development

Successfully merging a pull request may close this issue.

Robert/move amino stdtx cosmos/cosmos-sdk
2 participants
@aaronc @robert-zaremba