-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for protobuf TxGenerator and SIGN_MODE_DIRECT #6385
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6385 +/- ##
==========================================
+ Coverage 57.04% 57.30% +0.26%
==========================================
Files 481 491 +10
Lines 28939 29470 +531
==========================================
+ Hits 16507 16889 +382
- Misses 11258 11372 +114
- Partials 1174 1209 +35 |
…ronc/6213-sign-mode-direct
* WIP: added test for direct mode handler * updated code * Add msg * Update TxWrapper API * Fix pubkey declaration * Add pubkey for tests * Fix SetFee * Remove logs * Avoid global var declaration for tests * Add test for GetPubKeys * Fix direct signing tests * Add more test cases for GetSignBytes * Revert SetFee API * Remove logs * Refactor tests Co-authored-by: anilCSE <[email protected]> Co-authored-by: sahith-narahari <[email protected]>
…ronc/6213-sign-mode-direct
…ronc/6213-sign-mode-direct
…ronc/6213-sign-mode-direct
…ronc/6213-sign-mode-direct
…ronc/6213-sign-mode-direct
Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: Federico Kunze <[email protected]>
…os-sdk into sahith/6385-fixes
@fedekunze addressed all your review comments. The test coverage should be better now. @alexanderbez the only pending thing I see is figuring out this naming thing. What do you think? Would be good to get this merged soon to keep #6213 moving. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ref: #6213
Summary
This PR adds support for a protobuf
client.TxGenerator
with signing viaSIGN_MODE_DIRECT
.Details
Tx
additions/changes:client.TxGenerator
andclient.TxBuilder
for the new protobufTx
in the newx/auth/tx
package (the oldStdTx
will move tox/auth/tx/legacy
in a future PR)SignModeHandler
implementation forSIGN_MODE_DIRECT
TxRaw
proto type and updatesSignDoc
as well as doc comments to reflect the latest state of ADR 020, updatesSignerInfo
to usePublicKey
rather thanAny
.sdk.TestMsg
tocodec/testdata
adding protobuf supportx/auth/ante.SigVerifiableTx
tox/auth/signing.SigVerifiableTx
so that it can be used from other packagesSigFeeMemoTx
interface tox/auth/signing
which wrapssdk.Tx
,FeeTx
,TxWithMemo
andSigVerifiableTx
in a single interface and use this inclient.TxBuilder
. (I'm not sure this is well named... but functionally it makes sense because this is whatTxBuilder
actually supports and is standard throughout the SDK.)CompactBitArray.Size()
toCount()
and re-enablegogoproto.sizer
- this was causing a nasty bug and the protoSize
method shouldn't have been overridden.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer