-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test suite for client TxBuilder #6460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilcse
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
June 17, 2020 10:18
Codecov Report
@@ Coverage Diff @@
## master #6460 +/- ##
==========================================
+ Coverage 56.67% 56.78% +0.10%
==========================================
Files 478 478
Lines 28745 28745
==========================================
+ Hits 16291 16322 +31
+ Misses 11309 11277 -32
- Partials 1145 1146 +1 |
aaronc
requested changes
Jun 17, 2020
…s-sdk into anil/client_txbuilder_tests
aaronc
requested changes
Jun 17, 2020
aaronc
changed the title
Add tests for client TxBuilder
Add test suite for client TxBuilder
Jun 26, 2020
aaronc
approved these changes
Jun 26, 2020
sahith-narahari
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6213 .
This adds a
TxGeneratorTestSuite
which tests implementations ofclient.TxGenerator
andclient.TxBuilder
. It used in this PR to test the legacyStdTxGenerator
implementation and will be used in #6385 to test the new protobufTxGenerator
.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer