Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test suite for client TxBuilder #6460

Merged
merged 24 commits into from
Jun 29, 2020
Merged

Conversation

anilcse
Copy link
Collaborator

@anilcse anilcse commented Jun 17, 2020

Part of #6213 .

This adds a TxGeneratorTestSuite which tests implementations of client.TxGenerator and client.TxBuilder. It used in this PR to test the legacy StdTxGenerator implementation and will be used in #6385 to test the new protobuf TxGenerator.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #6460 into master will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6460      +/-   ##
==========================================
+ Coverage   56.67%   56.78%   +0.10%     
==========================================
  Files         478      478              
  Lines       28745    28745              
==========================================
+ Hits        16291    16322      +31     
+ Misses      11309    11277      -32     
- Partials     1145     1146       +1     

x/auth/types/client_tx_test.go Outdated Show resolved Hide resolved
x/auth/types/client_tx_test.go Outdated Show resolved Hide resolved
x/auth/types/client_tx_test.go Outdated Show resolved Hide resolved
x/auth/types/client_tx_test.go Outdated Show resolved Hide resolved
x/auth/types/client_tx_test.go Outdated Show resolved Hide resolved
x/auth/types/client_tx_test.go Outdated Show resolved Hide resolved
x/auth/types/client_tx_test.go Outdated Show resolved Hide resolved
@clevinson clevinson added this to the v0.39 milestone Jun 17, 2020
@anilcse anilcse requested a review from aaronc June 17, 2020 21:57
@anilcse anilcse marked this pull request as ready for review June 24, 2020 16:13
@aaronc aaronc marked this pull request as draft June 25, 2020 21:22
@aaronc aaronc changed the title Add tests for client TxBuilder Add test suite for client TxBuilder Jun 26, 2020
@aaronc aaronc marked this pull request as ready for review June 26, 2020 19:38
Copy link
Contributor

@sahith-narahari sahith-narahari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronc aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 29, 2020
@mergify mergify bot merged commit 74eb56d into master Jun 29, 2020
@mergify mergify bot deleted the anil/client_txbuilder_tests branch June 29, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants