Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RejectExtensionOptionsDecorator #6988

Merged
merged 16 commits into from
Aug 18, 2020
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Aug 7, 2020

ref: #6213

This adds an AnteDecorator to reject all transactions with TxBody.extension_options set. Users who want to use extension options need to override this. For the SDK, the correct behavior is to reject.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #6988 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6988      +/-   ##
==========================================
+ Coverage   54.79%   54.81%   +0.02%     
==========================================
  Files         541      542       +1     
  Lines       36889    36907      +18     
==========================================
+ Hits        20212    20230      +18     
  Misses      15021    15021              
  Partials     1656     1656              

@aaronc aaronc mentioned this pull request Aug 11, 2020
27 tasks
@aaronc aaronc marked this pull request as ready for review August 14, 2020 17:12
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comment on why we need a separate interface for extensions tx builders.

x/auth/tx/builder.go Show resolved Hide resolved
@aaronc aaronc added C:x/auth A:automerge Automatically merge PR once all prerequisites pass. labels Aug 18, 2020
@mergify mergify bot merged commit 94b3cc5 into master Aug 18, 2020
@mergify mergify bot deleted the aaronc/6213-reject-ext-opts branch August 18, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants