-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RejectExtensionOptionsDecorator #6988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6988 +/- ##
==========================================
+ Coverage 54.79% 54.81% +0.02%
==========================================
Files 541 542 +1
Lines 36889 36907 +18
==========================================
+ Hits 20212 20230 +18
Misses 15021 15021
Partials 1656 1656 |
aaronc
requested review from
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
August 14, 2020 17:12
anilcse
approved these changes
Aug 16, 2020
fedekunze
approved these changes
Aug 17, 2020
amaury1093
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, small comment on why we need a separate interface for extensions tx builders.
aaronc
added
C:x/auth
A:automerge
Automatically merge PR once all prerequisites pass.
labels
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #6213
This adds an
AnteDecorator
to reject all transactions withTxBody.extension_options
set. Users who want to use extension options need to override this. For the SDK, the correct behavior is to reject.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes