Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all IBC Msg types use pointers #6857

Merged
merged 5 commits into from
Jul 27, 2020
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jul 27, 2020

This is a work-around for missing protobuf definition for some IBC types. At the very least they need to be used in pointer versions (i.e. *MsgCreateClient) to pass protobuf unit tests. Needed for #6213.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #6857 into master will increase coverage by 5.94%.
The diff coverage is 60.95%.

@@            Coverage Diff             @@
##           master    #6857      +/-   ##
==========================================
+ Coverage   55.60%   61.54%   +5.94%     
==========================================
  Files         457      508      +51     
  Lines       27440    31523    +4083     
==========================================
+ Hits        15257    19402    +4145     
+ Misses      11083    10611     -472     
- Partials     1100     1510     +410     

@aaronc aaronc added the x/ibc label Jul 27, 2020
@aaronc aaronc marked this pull request as ready for review July 27, 2020 14:38
@aaronc aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 27, 2020
@mergify mergify bot merged commit 20488b4 into master Jul 27, 2020
@mergify mergify bot deleted the aaronc/ibc-proto-workaround branch July 27, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants