Update simapp helpers to use Tx generator #6655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6655 +/- ##
==========================================
- Coverage 58.54% 58.46% -0.09%
==========================================
Files 511 511
Lines 30981 31047 +66
==========================================
+ Hits 18139 18151 +12
- Misses 11495 11543 +48
- Partials 1347 1353 +6 |
sahith-narahari
commented
Jul 9, 2020
alexanderbez
reviewed
Jul 9, 2020
…-sdk into sahith/update-simapp-gentx
|
This pull request introduces 15 alerts when merging ba9d70c into d23c779 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 2531b7b into d23c779 - view on LGTM.com new alerts:
|
sahith-narahari
requested review from
alessio,
clevinson and
jgimeno
as code owners
fedekunze
reviewed
Jul 13, 2020
Co-authored-by: Federico Kunze <[email protected]>
aaronc
reviewed
Jul 13, 2020
aaronc
approved these changes
Jul 13, 2020
anilcse
approved these changes
Jul 14, 2020
Co-authored-by: Aaron Craelius <[email protected]>
sahith-narahari
added
the
A:automerge
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* update helpers to use tx generator * update modules to use tx generator * add todo * update ibc to use txG * fix lint * Eliminate panics from Gentx * update module ops * fix lgtm alert * update ibc with txG * Remove todo Co-authored-by: Federico Kunze <[email protected]> * move simapp/helpers to test_helpers * revert simapp/helpers to test_helpers * revert renaming * address suggestion Co-authored-by: Aaron Craelius <[email protected]> * fix tests Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Aaron Craelius <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #6213
This is part of breakdown of #6216 into smaller PRs
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes