-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST tx endpoint backwards compatibility #6801
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6801 +/- ##
==========================================
- Coverage 61.56% 61.40% -0.17%
==========================================
Files 511 517 +6
Lines 31879 32050 +171
==========================================
+ Hits 19626 19679 +53
- Misses 10701 10802 +101
- Partials 1552 1569 +17 |
…hith/mig-auth-rest
Sorry about the review request chatter. There's a bug on github mobile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed:
- client/tx/legacy.go and tests
- x/auth/client/rest/{decode,encode} and tests
they lgtm, though I'm not super familiar with the code either.
…hith/mig-auth-rest
…hith/mig-auth-rest
@fedekunze I have did what I could to increase test coverage including:
There are likely still some cases that are hard to trigger with a test (such as passing in a Let me know what you think. |
Description
Migrates x/auth
encode
,decode
andbroadcast
REST endpoints, as well as REST tx endpoints in general.This does conversion to the native tx format (protobuf or amino) behind the scenes allowing existing clients to still submit amino JSON
StdTx
transactions to protobuf blockchains.ref: #6213
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes