Remove old tx code from rest #6939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6939 +/- ##
==========================================
+ Coverage 61.80% 65.24% +3.44%
==========================================
Files 521 391 -130
Lines 32166 24318 -7848
==========================================
- Hits 19880 15867 -4013
+ Misses 10672 7213 -3459
+ Partials 1614 1238 -376 |
|
@sahith-narahari you can delete the x/ibc ones too. AFAIK they are not used or tested at all |
I updated x/ibc to use |
sahith-narahari
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
anilcse
reviewed
Aug 4, 2020
There was a problem hiding this comment.
looks good. Can you also clean up rest queries, for ref here: https://github.com/cosmos/cosmos-sdk/blob/master/x/bank/client/rest/query.go#L40-L41
amaury1093
approved these changes
Aug 5, 2020
alexanderbez
reviewed
Aug 5, 2020
alexanderbez
approved these changes
Aug 5, 2020
sahith-narahari
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes old tx code from rest. I also updated
x/ibcto useWriteGeneratedTxResponse. I'll do a followup PR to removex/auth/types/TxBuilderRef: #6213
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes