Reduce complexity of erasing elements from vectors in PATTauHybridProducer

[mbluj]

PR description:

This PR contains an update to PATTauHybridProducer to reduce complexity of erasing elements from vectors by using std::remove_if instead of looping over elements of the vectors. Originally proposed in #44067 (comment).

PR validation:

Successfully tested with 12634.0_TTbar_14TeV+2023PU wf like this: runTheMatrix.py -l 12634.0 -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Can be backported together with #44067 to 14_0 for 2024 Nano production.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44266/39285

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

• PhysicsTools/PatAlgos (reconstruction, xpog)

@hqucms, @cmsbuild, @mandrenguyen, @vlimant, @jfernan2 can you please review it and eventually sign? Thanks.
@Senphy, @AlexDeMoor, @jdolen, @ahinzmann, @nhanvtran, @seemasharmafnal, @AnnikaStein, @Ming-Yan, @gkasieczka, @hatakeyamak, @jdamgov, @mbluj, @gpetruc, @emilbols, @andrzejnovak, @demuller, @mmarionncern, @azotz, @JyothsnaKomaragiri, @schoef, @mariadalfonso, @rappoccio, @gouskos this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[mandrenguyen]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddc12c/37829/summary.html
COMMIT: b8a0932
CMSSW: CMSSW_14_1_X_2024-02-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44266/37829/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @wddgit Delete function warnAboutLegacyModules (no longer needed) #44254
• @mmusich add failsafes for protecting the alpaka customization against Fake HLT menus #44221
• @fwyzard Add missing newlines in TBDataFormats modules #44248
• @mmusich Tracker alignment offline validation tools: miscellaneous fixes to muon-related validations #44252
• @brusale Add FlatPtGeneration to CloseByParticleGun #44008
• @theochatzis Jet phi variable in L1 correction #44084
• @mbluj Refactoring of Phase1 OMTF emulator code #43687
• @fwyzard Add missing newlines in Analysis modules #44224
• @fwyzard Add missing newlines in Reconstruction modules #44246
• @fwyzard Add missing newlines in PhysicsTools modules #44245
• @jmduarte Add Phase-2 Level-1 trigger ML MET emulator #43633
• @jsamudio Remove unnecessary ESProducer from LegacyPFClusterProducer #44070
• @bsunanda Run3-gex176A update the cfg files in SimG4Core/PrintGeomInfo to access the new scenario #44037
• @wddgit Improve ExternalGeneratorFilter to handle a stream skipping a lumi #43783
• @wddgit Migrate away from OwnVector<TrackingRegion> #44063
• @wddgit Migrate away from OwnVector<BaseTrackerRecHit> #44047
• @mseidel42 Adapt ParticleLevelProducer for Rivet 3.1.10 #43973
• @makortel Erase from correct vector in PATTauHybridProducer #44067
• @chnielse Adding Phase 2 HPS Tau Emulator #43848
• @bsunanda Run3-gex176E Update the rpc geometry description for 2024 scenario #44093

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddc12c/37829/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddc12c/37829/git-merge-result

Comparison Summary

Summary:

• You potentially added 92 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 49 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3338784
• DQMHistoTests: Total failures: 74
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338688
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

type performance-improvements

[mandrenguyen]

+1

[vlimant]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1