-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce complexity of erasing elements from vectors in PATTauHybridProducer #44266
Conversation
Erase elements of candidate vectors with remove_if instead of looping over the vectors to reduce complexity
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44266/39285
|
A new Pull Request was created by @mbluj for master. It involves the following packages:
@hqucms, @cmsbuild, @mandrenguyen, @vlimant, @jfernan2 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
type performance-improvements |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR contains an update to
PATTauHybridProducer
to reduce complexity of erasing elements from vectors by usingstd::remove_if
instead of looping over elements of the vectors. Originally proposed in #44067 (comment).PR validation:
Successfully tested with 12634.0_TTbar_14TeV+2023PU wf like this:
runTheMatrix.py -l 12634.0 -i all --ibeos
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Can be backported together with #44067 to 14_0 for 2024 Nano production.