Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker alignment offline validation tools: miscellaneous fixes to muon-related validations #44252

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 27, 2024

PR description:

This PR contains a number of miscellaneous fixes / improvements in order to be able to run the Zmumu and DiMuonVertex tools in the tracker alignment all-in-one meta-tool, collecting feedback from users:

PR validation:

Run successfully the augmented unit tests via:

  • scram b runtests_Zmumuall
  • scram b runtests_DiMuonVall

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport but will need to be backported to CMSS_14_0_X for 2023 operations

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 27, 2024

cms-bot internal usage

@mmusich mmusich force-pushed the mm_dev_addUnitTests_forZmmValidation_14_1_X branch from afc402e to 1301189 Compare February 27, 2024 21:13
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44252/39263

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@saumyaphor4252, @perrotta, @consuegs, @cmsbuild can you please review it and eventually sign? Thanks.
@tlampen, @yuanchao, @mmusich, @adewit, @tocheng, @rsreds this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Feb 27, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f37a99/37778/summary.html
COMMIT: 1301189
CMSSW: CMSSW_14_1_X_2024-02-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44252/37778/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+alca

  • New unit tests succeed

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants