Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing newlines in TBDataFormats modules #44248

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 27, 2024

PR description:

Add missing newlines at the end of the files under

TBDataFormats/EcalTBObjects

.

PR validation:

None.

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 27, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 27, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44248/39257

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • TBDataFormats/EcalTBObjects (analysis)

@tvami can you please review it and eventually sign? Thanks.
@ReyerBand, @rchatter, @thomreis, @wang0jin, @missirol, @argiro this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-07314a/37771/summary.html
COMMIT: 5f5e3a8
CMSSW: CMSSW_14_1_X_2024-02-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44248/37771/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@tvami
Copy link
Contributor

tvami commented Feb 29, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f383e4c into cms-sw:master Feb 29, 2024
11 checks passed
@fwyzard fwyzard deleted the add_final_newline_TBDataFormats branch March 2, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants