Remove unnecessary ESProducer from LegacyPFClusterProducer #44070

jsamudio · 2024-02-24T06:16:14Z

PR description:

This PR removes pfClusterParamsESProducer from LegacyPFClusterProducer as it is not used in the producer. Configurations for offline workflows and customizeHLTforAlpaka.py are updated to reflect this change.

PR validation:

Tested on workflow 12434.423 which uses the HLT customization and HCAL only configuration for this producer.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport.

@hatakeyamak @fwyzard @waredjeb

cmsbuild · 2024-02-24T06:16:40Z

cms-bot internal usage

cmsbuild · 2024-02-24T06:21:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44070/39028

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/customizeHLTforAlpaka.py modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964, Fix on muon_mvaID in NanoAOD #43976
- File RecoParticleFlow/PFClusterProducer/python/pfClusterHBHEAlpaka_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976

cmsbuild · 2024-02-24T06:22:18Z

A new Pull Request was created by @jsamudio for master.

It involves the following packages:

HLTrigger/Configuration (hlt)
RecoParticleFlow/PFClusterProducer (reconstruction)

@jfernan2, @cmsbuild, @Martin-Grunewald, @mmusich, @mandrenguyen can you please review it and eventually sign? Thanks.
@rovere, @felicepantaleo, @Martin-Grunewald, @hatakeyamak, @silviodonato, @missirol, @mmarionncern, @seemasharmafnal, @lgray, @sameasy this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

mmusich · 2024-02-24T06:49:20Z

enable gpu

mmusich · 2024-02-24T06:49:59Z

test parameters:

workflow_opts_gpu= -w upgrade
workflows_gpu = 12434.423

Martin-Grunewald · 2024-02-24T06:50:08Z

please test

mmusich · 2024-02-24T06:50:09Z

@cmsbuild, please test

mmusich · 2024-02-26T08:17:30Z

@cmsbuild, please abort

mmusich · 2024-02-26T08:17:40Z

@cmsbuild, please test

cmsbuild · 2024-02-26T15:27:24Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9cf765/37681/summary.html
COMMIT: 857a498
CMSSW: CMSSW_14_1_X_2024-02-25-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44070/37681/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 10 lines from the logs
Reco comparison results: 60 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3245365
DQMHistoTests: Total failures: 1192
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3244151
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 35 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 40949
DQMHistoTests: Total failures: 1169
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 39780
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 15 edm output root files, 4 DQM output files
TriggerResults: no differences found

mmusich · 2024-02-27T07:32:12Z

RecoParticleFlow/PFClusterProducer/plugins/LegacyPFClusterProducer.cc

@@ -68,7 +66,6 @@ class LegacyPFClusterProducer : public edm::stream::EDProducer<> {
    edm::ParameterSetDescription desc;
    desc.add<edm::InputTag>("src");
    desc.add<edm::InputTag>("PFRecHitsLabelIn");
-    desc.add<edm::ESInputTag>("pfClusterParams");


relaying an observation from @missirol, if this module has to be parsed in confDB we need to provide defaults in the fillDescription

Indeed, after the removal of pfClusterParams we still need default values in fillDescriptions added for:

InputTag src InputTag PFRecHitsLabelIn InputTag recHitsSource

Empty InputTags are fine, but the values must be there.

mmusich · 2024-02-27T07:33:06Z

type pf

Martin-Grunewald · 2024-02-27T16:59:46Z

@jsamudio

Could you please urgently address the above change? We'd need this (and the 14_0 bp) in the next 14_0 release. Thanks!

mmusich · 2024-02-28T09:52:40Z

please test with #44221

cmsbuild · 2024-02-28T12:35:04Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9cf765/37788/summary.html
COMMIT: 396a6dd
CMSSW: CMSSW_14_1_X_2024-02-27-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44070/37788/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 100 lines to the logs
Reco comparison results: 51 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3011576
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3011554
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

You potentially added 19 lines to the logs
Reco comparison results: 48 differences found in the comparisons
DQMHistoTests: Total files compared: 3
DQMHistoTests: Total histograms compared: 39740
DQMHistoTests: Total failures: 1488
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 38252
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
Checked 10 log files, 11 edm output root files, 3 DQM output files
TriggerResults: no differences found

Martin-Grunewald · 2024-02-28T12:44:37Z

+1

Martin-Grunewald · 2024-02-28T13:48:11Z

@cms-sw/reconstruction-l2 can you please sign this PR as well, as you have signed already the backport to 14_0? Thanks!
@jfernan2 @mandrenguyen

Martin-Grunewald · 2024-02-29T07:40:30Z

urgent
(It's backport is needed for the next 14_0 release).

mmusich · 2024-02-29T08:39:04Z

@cms-sw/reconstruction-l2 please do sign now. This is a showstopper for HLT integration

antoniovilela · 2024-02-29T10:38:34Z

@cms-sw/reconstruction-l2
Please do review & sign as soon as possible.
Thanks.

mandrenguyen · 2024-02-29T10:45:29Z

+1

cmsbuild · 2024-02-29T10:46:02Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44221

antoniovilela · 2024-02-29T10:47:01Z

+1

Remove unnecessary parameters from LegacyPFClusterProducer

857a498

cmsbuild added this to the CMSSW_14_1_X milestone Feb 24, 2024

cmsbuild added reconstruction-pending hlt-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 24, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 24, 2024

jsamudio mentioned this pull request Feb 24, 2024

[14.0.X] Remove unnecessary ESProducer from LegacyPFClusterProducer #44071

Merged

cmsbuild added tests-started and removed tests-pending labels Feb 24, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 26, 2024

mmusich reviewed Feb 27, 2024

View reviewed changes

cmsbuild added the pf label Feb 27, 2024

cmsbuild mentioned this pull request Feb 27, 2024

add failsafes for protecting the alpaka customization against Fake HLT menus #44221

Merged

cmsbuild added tests-rejected and removed tests-started labels Feb 28, 2024

cmsbuild added requires-external tests-started and removed tests-rejected labels Feb 28, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 28, 2024

cmsbuild added hlt-approved and removed hlt-pending labels Feb 28, 2024

cmsbuild added the urgent label Feb 29, 2024

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Feb 29, 2024

cmsbuild added orp-approved and removed orp-pending labels Feb 29, 2024

cmsbuild merged commit 573938a into cms-sw:master Feb 29, 2024
15 checks passed

This was referenced Feb 29, 2024

Fix some minor RooFit user errors #44069

Merged

Reduce complexity of erasing elements from vectors in PATTauHybridProducer #44266

Merged

Small fix in HeterogeneousCore/AlpakaCore/README.md #44279

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unnecessary ESProducer from LegacyPFClusterProducer #44070

Remove unnecessary ESProducer from LegacyPFClusterProducer #44070

jsamudio commented Feb 24, 2024

cmsbuild commented Feb 24, 2024 •

edited

Loading

cmsbuild commented Feb 24, 2024

cmsbuild commented Feb 24, 2024

mmusich commented Feb 24, 2024

mmusich commented Feb 24, 2024

Martin-Grunewald commented Feb 24, 2024

mmusich commented Feb 24, 2024

mmusich commented Feb 26, 2024

mmusich commented Feb 26, 2024

cmsbuild commented Feb 26, 2024

mmusich Feb 27, 2024

Martin-Grunewald Feb 27, 2024

mmusich commented Feb 27, 2024

Martin-Grunewald commented Feb 27, 2024

mmusich commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

Martin-Grunewald commented Feb 28, 2024

Martin-Grunewald commented Feb 28, 2024

Martin-Grunewald commented Feb 29, 2024 •

edited

Loading

mmusich commented Feb 29, 2024

antoniovilela commented Feb 29, 2024

mandrenguyen commented Feb 29, 2024

cmsbuild commented Feb 29, 2024

antoniovilela commented Feb 29, 2024

Remove unnecessary ESProducer from LegacyPFClusterProducer #44070

Remove unnecessary ESProducer from LegacyPFClusterProducer #44070

Conversation

jsamudio commented Feb 24, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Feb 24, 2024 • edited Loading

cmsbuild commented Feb 24, 2024

cmsbuild commented Feb 24, 2024

mmusich commented Feb 24, 2024

mmusich commented Feb 24, 2024

Martin-Grunewald commented Feb 24, 2024

mmusich commented Feb 24, 2024

mmusich commented Feb 26, 2024

mmusich commented Feb 26, 2024

cmsbuild commented Feb 26, 2024

Comparison Summary

GPU Comparison Summary

mmusich Feb 27, 2024

Choose a reason for hiding this comment

Martin-Grunewald Feb 27, 2024

Choose a reason for hiding this comment

mmusich commented Feb 27, 2024

Martin-Grunewald commented Feb 27, 2024

mmusich commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

Comparison Summary

GPU Comparison Summary

Martin-Grunewald commented Feb 28, 2024

Martin-Grunewald commented Feb 28, 2024

Martin-Grunewald commented Feb 29, 2024 • edited Loading

mmusich commented Feb 29, 2024

antoniovilela commented Feb 29, 2024

mandrenguyen commented Feb 29, 2024

cmsbuild commented Feb 29, 2024

antoniovilela commented Feb 29, 2024

cmsbuild commented Feb 24, 2024 •

edited

Loading

Martin-Grunewald commented Feb 29, 2024 •

edited

Loading