-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary ESProducer from LegacyPFClusterProducer #44070
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44070/39028
|
A new Pull Request was created by @jsamudio for master. It involves the following packages:
@jfernan2, @cmsbuild, @Martin-Grunewald, @mmusich, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
enable gpu |
test parameters:
|
please test |
@cmsbuild, please test |
@cmsbuild, please abort |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9cf765/37681/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
@@ -68,7 +66,6 @@ class LegacyPFClusterProducer : public edm::stream::EDProducer<> { | |||
edm::ParameterSetDescription desc; | |||
desc.add<edm::InputTag>("src"); | |||
desc.add<edm::InputTag>("PFRecHitsLabelIn"); | |||
desc.add<edm::ESInputTag>("pfClusterParams"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relaying an observation from @missirol, if this module has to be parsed in confDB we need to provide defaults in the fillDescription
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, after the removal of pfClusterParams
we still need default values in fillDescriptions added for:
InputTag src
InputTag PFRecHitsLabelIn
InputTag recHitsSource
Empty InputTags are fine, but the values must be there.
type pf |
Could you please urgently address the above change? We'd need this (and the 14_0 bp) in the next 14_0 release. Thanks! |
please test with #44221 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9cf765/37788/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
+1 |
@cms-sw/reconstruction-l2 can you please sign this PR as well, as you have signed already the backport to 14_0? Thanks! |
urgent |
@cms-sw/reconstruction-l2 please do sign now. This is a showstopper for HLT integration |
@cms-sw/reconstruction-l2 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR removes
pfClusterParamsESProducer
fromLegacyPFClusterProducer
as it is not used in the producer. Configurations for offline workflows andcustomizeHLTforAlpaka.py
are updated to reflect this change.PR validation:
Tested on workflow
12434.423
which uses the HLT customization and HCAL only configuration for this producer.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport.
@hatakeyamak @fwyzard @waredjeb