Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add failsafes for protecting the alpaka customization against Fake HLT menus #44221

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 27, 2024

fixes #44119

PR description:

TItle says it all, see #44119 for discussion

PR validation:

runTheMatrix.py --what gpu -l 12434.402 runs fine in CMSSW_14_1_GPU_X_2024-02-26-2300 on the lxplus-gpu cluster.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, to be backported to 14.0.X

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 27, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 27, 2024

test parameters:

  • workflow_opts_gpu= -w upgrade
  • workflows_gpu = 12434.402, 12434.403, 12434.404, 12434.412, 12450.402, 12450.403, 12450.404

@mmusich
Copy link
Contributor Author

mmusich commented Feb 27, 2024

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Feb 27, 2024

code-checks

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44221/39226

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Feb 27, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8a684/37738/summary.html
COMMIT: ad70f92
CMSSW: CMSSW_14_1_X_2024-02-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44221/37738/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Feb 27, 2024

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Feb 27, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Feb 28, 2024

are tests stuck here?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8a684/37763/summary.html
COMMIT: ad70f92
CMSSW: CMSSW_14_1_X_2024-02-27-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44221/37763/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

There are some workflows for which there are errors in the baseline:
12434.423 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Feb 28, 2024

+hlt

  • technical

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

REMINDER @rappoccio, @sextonkennedy, @antoniovilela: This PR was tested with #44070, please check if they should be merged together

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 65ae758 into cms-sw:master Feb 29, 2024
15 checks passed
@mmusich mmusich deleted the mm_dev_protect_fakeMenus_in_customizeForAlpak_14_1_X branch February 29, 2024 12:06
@mmusich mmusich changed the title add failsafes for protecting the alpaka customization agains Fake HLT menus add failsafes for protecting the alpaka customization against Fake HLT menus Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GPU] Workflow failures when running the alpaka customization in presence of a Fake menu
3 participants