[GPU] Workflow failures when running the alpaka customization in presence of a Fake menu
#44119
Comments
|
assign hlt, heterogeneous |
|
New categories assigned: hlt,heterogeneous @Martin-Grunewald,@mmusich,@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
cms-bot internal usage |
|
A new Issue was created by @mmusich. @smuzaffar, @antoniovilela, @Dr15Jones, @makortel, @rappoccio, @sextonkennedy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
|
@thomreis FYI |
|
The customisation should check whether HLTDoFullUnpackingEgammaEcalWithoutPreshowerTask actually exists, before messing with it. |
|
What menu was used for this? |
Fake one. See above. In any case it does not matter. Please provide a fix, since the customization needs to run irrespectively |
|
Hmm, alternatively, it may be best to remove alpaka from these (failing) 2023 (HLT) workflows (as those are now using the Fake menus). Testing alpaka on Fake HLT menus does not make much sense! |
this is what this PR #44075 is going to do . On the other hand the customization should not break in any circumstance IMHO. |
in order to achieve that, though also all the other customization pieces need to comply, perhaps better to remove all years with the fake menu from the alpaka customization |
|
New categories assigned: pdmv @AdrianoDee,@sunilUIET,@miquork you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
Would add a condition to this line would fix this? if hasattr(process, 'HLTDoFullUnpackingEgammaEcalWithoutPreshowerTask') and hasattr(process, 'HLTPreshowerTask'):
process.HLTDoFullUnpackingEgammaEcalTask = cms.ConditionalTask(process.HLTDoFullUnpackingEgammaEcalWithoutPreshowerTask, process.HLTPreshowerTask) |
|
This error, yes, I think so. |
It does, but then it fails with: |
|
But that is not and issue of the ECAL customisation anymore. Looks like Pixel in this case. |
right, but it does not solve the issue. |
Well it would solve this issue. But there seem to be others. |
mmusich
changed the title
HLTDoFullUnpackingEgammaEcalWithoutPreshowerTaskFake menu
|
I guess it is faster to get the PRs in, rather than making alpaka customisations failsafe - given that the alpaka customisation will be folded into the ConfDb menus within a couple of weeks? |
I edited the issue title to be more inclusive, so no, unfortunately it's not an adequate fix. |
getting the PR in will probably remove the failures from the IBs tests, but the workflows will remain broken IIUC |
diff --git a/HLTrigger/Configuration/python/customizeHLTforAlpaka.py b/HLTrigger/Configuration/python/customizeHLTforAlpaka.py
index d1ca276fb3e..a9bdb2feae0 100644
--- a/HLTrigger/Configuration/python/customizeHLTforAlpaka.py
+++ b/HLTrigger/Configuration/python/customizeHLTforAlpaka.py
@@ -190,6 +190,10 @@ def customizeHLTforAlpakaParticleFlowClustering(process):
pfRecHits = cms.InputTag("hltPFRecHitSoAProducerHCALCPUSerial"),
)
+ ## failsafe for fake menus
+ if(not hasattr(process,'hltParticleFlowClusterHBHE')):
+ return process
+
process.hltLegacyPFClusterProducer = cms.EDProducer("LegacyPFClusterProducer",
src = cms.InputTag("hltPFClusterSoAProducer"),
pfClusterParams = cms.ESInputTag("pfClusterParamsESProducer:"),
@@ -725,6 +729,10 @@ def customizeHLTforAlpakaPixelRecoVertexing(process):
src = cms.InputTag("hltPixelVerticesCPUSerial")
)
+ ## failsafe for fake menus
+ if(not hasattr(process,'hltTrimmedPixelVertices')):
+ return process
+
process.HLTRecopixelvertexingTask = cms.ConditionalTask(
process.HLTRecoPixelTracksTask,
process.hltPixelVerticesSoA,
@@ -905,7 +913,9 @@ def customizeHLTforAlpakaEcalLocalReco(process):
if hasattr(process, 'hltEcalUncalibRecHitSoA'):
delattr(process, 'hltEcalUncalibRecHitSoA')
- process.HLTDoFullUnpackingEgammaEcalTask = cms.ConditionalTask(process.HLTDoFullUnpackingEgammaEcalWithoutPreshowerTask, process.HLTPreshowerTask)
+ ## failsafe for fake menus
+ if hasattr(process, 'HLTDoFullUnpackingEgammaEcalWithoutPreshowerTask') and hasattr(process, 'HLTPreshowerTask'):
+ process.HLTDoFullUnpackingEgammaEcalTask = cms.ConditionalTask(process.HLTDoFullUnpackingEgammaEcalWithoutPreshowerTask, process.HLTPreshowerTask)
return process
this seems to be enough to avoid runtime failures. |
this assumes that we are (correctly) running the |
Ok, on a second thought this could overcomplicate things. Would protect the customizer with the failsafes. |
Agreed, you just preceded me. |
|
+heterogeneous |
|
+hlt
|
Several workflows {12434,12450}.{402,403,404,412} fail in GPU IB tests in CMSSW_14_1_GPU_X_2024-02-26-2300 along:
this likely comes from the integration of #44026 that moved
@relval2023to@Fake2.The text was updated successfully, but these errors were encountered: