Updates for 2024 Wfs (PR Testing, IBs, Patatrack, inputs) #44075

AdrianoDee · 2024-02-25T00:31:04Z

PR description:

This PR updates the wfs used in PR testing, IB test (standard and GPU). It includes f77b3b3 from @mmusich.

For the moment the 2023 wfs are kept as they are with the idea of reducing them later this year.

The default input GEN-SIM datasets for 2024 conditions are updated to 14_0_0_pre3 RelVals.

cmsbuild · 2024-02-25T00:31:34Z

cms-bot internal usage

cmsbuild · 2024-02-25T00:35:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44075/39037

This PR adds an extra 88KB to repository

cmsbuild · 2024-02-25T00:36:17Z

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@srimanob, @cmsbuild, @miquork, @sunilUIET, @AdrianoDee, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @slomeo, @missirol, @fabiocos this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2024-02-25T00:39:02Z

enable gpu

AdrianoDee · 2024-02-25T00:39:10Z

please test

cmsbuild · 2024-02-25T04:19:58Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f11bf/37661/summary.html
COMMIT: 222be81
CMSSW: CMSSW_14_1_X_2024-02-24-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44075/37661/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 12834.7

RelVals-INPUT

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 19 differences found in the comparisons
DQMHistoTests: Total files compared: 3
DQMHistoTests: Total histograms compared: 39740
DQMHistoTests: Total failures: 668
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 39072
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
Checked 8 log files, 10 edm output root files, 3 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-02-25T09:37:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44075/39040

This PR adds an extra 92KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_2017.py modified in PR(s): Move relval2023 to point to Fake2 for HLT [141X] #44026
- File Configuration/PyReleaseValidation/python/relval_gpu.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Remove deprecated heavy-ion reconstruction #43824, [PPS] Added gtStage2DigisAlCaRecoProducer to ALCARECOPRODUCER #44044
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add run3 tracking low pu era #33532, add Era_Run3_2024, Era_Run3_2025, Tier0 reco scenario for 2024, and change default era in PyReleaseValidation #43761, Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964, Fix on muon_mvaID in NanoAOD #43976, Move relval2023 to point to Fake2 for HLT [141X] #44026
- File Configuration/PyReleaseValidation/scripts/runTheMatrix.py modified in PR(s): Remove deprecated heavy-ion reconstruction #43824, Move relval2023 to point to Fake2 for HLT [141X] #44026

cmsbuild · 2024-02-25T17:09:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44075/39047

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_gpu.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Remove deprecated heavy-ion reconstruction #43824, [PPS] Added gtStage2DigisAlCaRecoProducer to ALCARECOPRODUCER #44044
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add run3 tracking low pu era #33532, add Era_Run3_2024, Era_Run3_2025, Tier0 reco scenario for 2024, and change default era in PyReleaseValidation #43761, Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964, Fix on muon_mvaID in NanoAOD #43976, Move relval2023 to point to Fake2 for HLT [141X] #44026
- File Configuration/PyReleaseValidation/scripts/runTheMatrix.py modified in PR(s): Remove deprecated heavy-ion reconstruction #43824

cmsbuild · 2024-02-25T19:37:10Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f11bf/37674/summary.html
COMMIT: ddba424
CMSSW: CMSSW_14_1_X_2024-02-25-0000/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44075/37674/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 72 lines to the logs
Reco comparison results: 44 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 2756234
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2756209
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
Checked 187 log files, 146 edm output root files, 45 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 22 differences found in the comparisons
DQMHistoTests: Total files compared: 3
DQMHistoTests: Total histograms compared: 39740
DQMHistoTests: Total failures: 986
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 38754
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
Checked 8 log files, 10 edm output root files, 3 DQM output files
TriggerResults: no differences found

mmusich · 2024-02-26T08:08:53Z

Configuration/PyReleaseValidation/scripts/runTheMatrix.py

-                    12434.7,    # RelValTTbar_14TeV             mkFit
+                    11634.0,    # TTbar_14TeV                   2021
+                    13234.0,    # RelValTTbar_14TeV             2021 FastsSim
+                    12434.0,    # RelValTTbar_14TeV             2023


any strong reason to keep this in the system?

Not really strong, actually. Seemed harmless to just keep one 2023 test for the moment.

OK, just for the record, this is what is causing the changes explained at #44026 (comment).

Hi,
I think we should keep at least one workflow around, to monitor its healthy if we will have legacy wf later (not hlt part, of course).

I think we should keep at least one workflow around, to monitor its healthy if we will have legacy wf later

not proposing to remove entirely btw, just in the limited matrix.

cmsbuild · 2024-02-26T09:39:05Z

REMINDER @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with #44026, please check if they should be merged together

AdrianoDee · 2024-02-26T10:27:09Z

+pdmv

mmusich · 2024-02-27T11:14:27Z

urgent

mmusich · 2024-02-27T11:14:36Z

@cms-sw/upgrade-l2 can you please have a look?

srimanob · 2024-02-27T13:20:42Z

+Upgrade

cmsbuild · 2024-02-27T13:21:02Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-02-28T16:37:23Z

+1

exchange the 2023 limited matrix workflows with the 2024 ones

f77b3b3

cmsbuild added this to the CMSSW_14_1_X milestone Feb 25, 2024

cmsbuild added pending-signatures tests-pending orp-pending pdmv-pending upgrade-pending code-checks-pending labels Feb 25, 2024

AdrianoDee mentioned this pull request Feb 25, 2024

[14_0_X] Updates for 2024 Wfs (PR Testing, IBs, Patatrack, inputs) #44076

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 25, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 25, 2024

This was referenced Feb 25, 2024

Move relval2023 to point to Fake2 for HLT [140X] #44027

Merged

Update defaultDataSets for RelVals (2024 and Phase2) #43982

Open

coverage of 2024 wfs in runTheMatrix, PR tests, IBs #44028

Closed

cmsbuild added tests-rejected and removed tests-started labels Feb 25, 2024

AdrianoDee force-pushed the wfs_2024_141X branch from 222be81 to f766eca Compare February 25, 2024 09:30

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Feb 25, 2024

cmsbuild added tests-started code-checks-pending labels Feb 25, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 25, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 25, 2024

mmusich reviewed Feb 26, 2024

View reviewed changes

cmsbuild added pdmv-approved and removed pdmv-pending labels Feb 26, 2024

cmsbuild mentioned this pull request Feb 26, 2024

[PPS] Added gtStage2DigisAlCaRecoProducer to ALCARECOPRODUCER #44044

Merged

mmusich mentioned this pull request Feb 27, 2024

[GPU] Workflow failures when running the alpaka customization in presence of a Fake menu #44119

Closed

cmsbuild added the urgent label Feb 27, 2024

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Feb 27, 2024

cmsbuild added orp-approved and removed orp-pending labels Feb 28, 2024

cmsbuild merged commit ed75f32 into cms-sw:master Feb 28, 2024
14 checks passed

cmsbuild mentioned this pull request Feb 29, 2024

Updated root to tip of branch master cms-sw/cmsdist#9034

Closed

srimanob mentioned this pull request Sep 19, 2024

Add 2024 FastSim workflow #46068

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates for 2024 Wfs (PR Testing, IBs, Patatrack, inputs) #44075

Updates for 2024 Wfs (PR Testing, IBs, Patatrack, inputs) #44075

AdrianoDee commented Feb 25, 2024

cmsbuild commented Feb 25, 2024 •

edited

Loading

cmsbuild commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

AdrianoDee commented Feb 25, 2024

AdrianoDee commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

mmusich Feb 26, 2024

AdrianoDee Feb 26, 2024

mmusich Feb 26, 2024

srimanob Feb 26, 2024

mmusich Feb 26, 2024

cmsbuild commented Feb 26, 2024

AdrianoDee commented Feb 26, 2024

mmusich commented Feb 27, 2024

mmusich commented Feb 27, 2024

srimanob commented Feb 27, 2024

cmsbuild commented Feb 27, 2024

antoniovilela commented Feb 28, 2024

Updates for 2024 Wfs (PR Testing, IBs, Patatrack, inputs) #44075

Updates for 2024 Wfs (PR Testing, IBs, Patatrack, inputs) #44075

Conversation

AdrianoDee commented Feb 25, 2024

PR description:

cmsbuild commented Feb 25, 2024 • edited Loading

cmsbuild commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

AdrianoDee commented Feb 25, 2024

AdrianoDee commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

RelVals

RelVals-INPUT

GPU Comparison Summary

cmsbuild commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

Comparison Summary

GPU Comparison Summary

mmusich Feb 26, 2024

Choose a reason for hiding this comment

AdrianoDee Feb 26, 2024

Choose a reason for hiding this comment

mmusich Feb 26, 2024

Choose a reason for hiding this comment

srimanob Feb 26, 2024

Choose a reason for hiding this comment

mmusich Feb 26, 2024

Choose a reason for hiding this comment

cmsbuild commented Feb 26, 2024

AdrianoDee commented Feb 26, 2024

mmusich commented Feb 27, 2024

mmusich commented Feb 27, 2024

srimanob commented Feb 27, 2024

cmsbuild commented Feb 27, 2024

antoniovilela commented Feb 28, 2024

cmsbuild commented Feb 25, 2024 •

edited

Loading