Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for 2024 Wfs (PR Testing, IBs, Patatrack, inputs) #44075

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

AdrianoDee
Copy link
Contributor

PR description:

This PR updates the wfs used in PR testing, IB test (standard and GPU). It includes f77b3b3 from @mmusich.

For the moment the 2023 wfs are kept as they are with the idea of reducing them later this year.

The default input GEN-SIM datasets for 2024 conditions are updated to 14_0_0_pre3 RelVals.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 25, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44075/39037

  • This PR adds an extra 88KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@srimanob, @cmsbuild, @miquork, @sunilUIET, @AdrianoDee, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @slomeo, @missirol, @fabiocos this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

enable gpu

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f11bf/37661/summary.html
COMMIT: 222be81
CMSSW: CMSSW_14_1_X_2024-02-24-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44075/37661/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 12834.7

RelVals-INPUT

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 19 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 668
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39072
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44075/39040

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44075/39047

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f11bf/37674/summary.html
COMMIT: ddba424
CMSSW: CMSSW_14_1_X_2024-02-25-0000/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44075/37674/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 72 lines to the logs
  • Reco comparison results: 44 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 2756234
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2756209
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 187 log files, 146 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 22 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 986
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38754
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

12434.7, # RelValTTbar_14TeV mkFit
11634.0, # TTbar_14TeV 2021
13234.0, # RelValTTbar_14TeV 2021 FastsSim
12434.0, # RelValTTbar_14TeV 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any strong reason to keep this in the system?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really strong, actually. Seemed harmless to just keep one 2023 test for the moment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, just for the record, this is what is causing the changes explained at #44026 (comment).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I think we should keep at least one workflow around, to monitor its healthy if we will have legacy wf later (not hlt part, of course).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep at least one workflow around, to monitor its healthy if we will have legacy wf later

not proposing to remove entirely btw, just in the limited matrix.

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with #44026, please check if they should be merged together

@AdrianoDee
Copy link
Contributor Author

+pdmv

@mmusich
Copy link
Contributor

mmusich commented Feb 27, 2024

urgent

@mmusich
Copy link
Contributor

mmusich commented Feb 27, 2024

@cms-sw/upgrade-l2 can you please have a look?

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ed75f32 into cms-sw:master Feb 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants