Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move relval2023 to point to Fake2 for HLT [140X] #44027

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

Move relval2023 to point to Fake2 for HLT [141X]

The HLT menu of 2023 should be run in 13_0 or 13_2 used for 2023 data taking

PR validation:

TSG tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44026

14_0/14_1 are for 2024 HLT menus and data taking

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2024

A new Pull Request was created by @Martin-Grunewald for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/HLT (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@missirol, @silviodonato, @fabiocos this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2024

cms-bot internal usage

@Martin-Grunewald
Copy link
Contributor Author

@cms-sw/dqm-l2 @cms-sw/ppd-l2 @cms-sw/pdmv-l2 please take note!

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c455d0/37574/summary.html
COMMIT: 6c9f7cd
CMSSW: CMSSW_14_0_X_2024-02-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44027/37574/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 922 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 314 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3085748
  • DQMHistoTests: Total failures: 24031
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3061695
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -279171.20399999997 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): -41169.464 KiB HLT/JME
  • DQMHistoSizes: changed ( 12434.0,... ): -7299.500 KiB HLT/EXO
  • DQMHistoSizes: changed ( 12434.0,... ): -3626.419 KiB HLT/TOP
  • DQMHistoSizes: changed ( 12434.0,... ): -3311.738 KiB HLT/HIG
  • DQMHistoSizes: changed ( 12434.0,... ): -2827.491 KiB HLT/SUSY
  • DQMHistoSizes: changed ( 12434.0,... ): -2423.433 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 12434.0,... ): -1827.372 KiB HLT/BTV
  • DQMHistoSizes: changed ( 12434.0,... ): -1724.938 KiB HLT/Objects
  • DQMHistoSizes: changed ( 12434.0,... ): -1721.552 KiB HLT/EGM
  • DQMHistoSizes: changed ( 12434.0,... ): -1505.974 KiB HLT/B2G
  • DQMHistoSizes: changed ( 12434.0 ): ...
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 4 / 46 workflows

@cmsbuild
Copy link
Contributor

Pull request #44027 was updated. @mmusich, @AdrianoDee, @srimanob, @subirsarkar, @cmsbuild, @miquork, @Martin-Grunewald, @sunilUIET can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Feb 24, 2024

backport of #44026

@mmusich
Copy link
Contributor

mmusich commented Feb 24, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

Pull request #44027 was updated. @srimanob, @Martin-Grunewald, @subirsarkar, @mmusich, @sunilUIET, @miquork, @AdrianoDee, @cmsbuild can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Feb 24, 2024

@cmsbuild, please test

@AdrianoDee
Copy link
Contributor

please test with #44076

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c455d0/37677/summary.html
COMMIT: f97a1a9
CMSSW: CMSSW_14_0_X_2024-02-25-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44027/37677/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 27 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 108 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 2698901
  • DQMHistoTests: Total failures: 132
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2698747
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -156939.709 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 12434.0 ): -41173.651 KiB HLT/JME
  • DQMHistoSizes: changed ( 12434.0 ): -17513.427 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 12434.0 ): -10390.469 KiB HLT/SiStrip
  • DQMHistoSizes: changed ( 12434.0 ): -10237.354 KiB HLT/HCAL
  • DQMHistoSizes: changed ( 12434.0 ): -10124.201 KiB HLT/BTV
  • DQMHistoSizes: changed ( 12434.0 ): -10043.763 KiB HLT/EXO
  • DQMHistoSizes: changed ( 12434.0 ): -9232.246 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 12434.0 ): -9053.111 KiB HLT/Muon
  • DQMHistoSizes: changed ( 12434.0 ): -8697.605 KiB HLT/Pixel
  • DQMHistoSizes: changed ( 12434.0 ): -5317.474 KiB HLT/SUSYBSM
  • DQMHistoSizes: changed ( 12434.0 ): ...
  • Checked 187 log files, 146 edm output root files, 45 DQM output files
  • TriggerResults: found differences in 1 / 43 workflows

@mmusich
Copy link
Contributor

mmusich commented Feb 26, 2024

+hlt

  • first step towards removal of the 2023v12 frozen HLT table from 14.0.X (to be replace with the first 2024 menu when available).
  • changes in the wf 12434.0 (see DQM bin-by-bin comparison are understood as due to the fact that now (when combining this with PR [14_0_X] Updates for 2024 Wfs (PR Testing, IBs, Patatrack, inputs) #44076) this is the last 2023 MC workflow run in the limited matrix, and in 2023 workflows we now run the Fake menu, hence no HLT plots nor persistency of HLT decisions.

@mmusich
Copy link
Contributor

mmusich commented Feb 26, 2024

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 can you have a look and sign (if you're happy)?

@AdrianoDee
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44076

@Martin-Grunewald
Copy link
Contributor Author

urgent
Needed for next 14_0 release.

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

ping bot

@cmsbuild cmsbuild merged commit bd795ad into cms-sw:CMSSW_14_0_X Feb 29, 2024
10 checks passed
@mmusich mmusich deleted the HLTrelva2023ToFake2140X branch February 29, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants