Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move relval2023 to point to Fake2 for HLT [141X] #44026

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

Martin-Grunewald
Copy link
Contributor

@Martin-Grunewald Martin-Grunewald commented Feb 20, 2024

PR description:

Move relval2023 to point to Fake2 for HLT [141X]

The HLT menu of 2023 should be run in 13_0 or 13_2 used for 2023 data taking

PR validation:

TSG tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_0_X

14_0/14_1 are for 2024 HLT menus and data taking

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2024

cms-bot internal usage

@Martin-Grunewald
Copy link
Contributor Author

@cms-sw/dqm-l2 @cms-sw/ppd-l2 @cms-sw/pdmv-l2 please take note!

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44026/38959

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald for master.

It involves the following packages:

  • Configuration/HLT (hlt)

@mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@missirol, @fabiocos, @silviodonato this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Feb 20, 2024

I don't see any 2024 workflows in runTheMatrix.
Shouldn't we have at least something testing HLT in PR tests?

Also, if this is going to make it to pre1 and backported to 14_0; is @cms-sw/pdmv-l2 planning to consistently switch the relvals to a 2024 in the relvals?

@Martin-Grunewald
Copy link
Contributor Author

I agree!
For HLT this is preferred (we'll not maintain 2023 HLT menus in 14_0/14_1).
Who and where can one switch/add relvals to 2024?

@Martin-Grunewald
Copy link
Contributor Author

I created the related issue #44028

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cea27/37575/summary.html
COMMIT: 733ebc8
CMSSW: CMSSW_14_1_X_2024-02-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44026/37575/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 903 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 291 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3085511
  • DQMHistoTests: Total failures: 22831
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3062658
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -279171.20399999997 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): -41169.464 KiB HLT/JME
  • DQMHistoSizes: changed ( 12434.0,... ): -7299.500 KiB HLT/EXO
  • DQMHistoSizes: changed ( 12434.0,... ): -3626.419 KiB HLT/TOP
  • DQMHistoSizes: changed ( 12434.0,... ): -3311.738 KiB HLT/HIG
  • DQMHistoSizes: changed ( 12434.0,... ): -2827.491 KiB HLT/SUSY
  • DQMHistoSizes: changed ( 12434.0,... ): -2423.433 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 12434.0,... ): -1827.372 KiB HLT/BTV
  • DQMHistoSizes: changed ( 12434.0,... ): -1724.938 KiB HLT/Objects
  • DQMHistoSizes: changed ( 12434.0,... ): -1721.552 KiB HLT/EGM
  • DQMHistoSizes: changed ( 12434.0,... ): -1505.974 KiB HLT/B2G
  • DQMHistoSizes: changed ( 12434.0 ): ...
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 4 / 46 workflows

@mmusich
Copy link
Contributor

mmusich commented Feb 24, 2024

In the last push I've done the following things:

@cmsbuild
Copy link
Contributor

Pull request #44026 was updated. @mmusich, @AdrianoDee, @Martin-Grunewald, @subirsarkar, @miquork, @srimanob, @sunilUIET can you please check and sign again.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cea27/37671/summary.html
COMMIT: a11e1ef
CMSSW: CMSSW_14_1_X_2024-02-25-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44026/37671/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

RelVals-INPUT

@AdrianoDee
Copy link
Contributor

please test with #44075

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cea27/37676/summary.html
COMMIT: a11e1ef
CMSSW: CMSSW_14_1_X_2024-02-25-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44026/37676/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 49 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 103 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 2698865
  • DQMHistoTests: Total failures: 129
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2698714
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -156939.709 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 12434.0 ): -41173.651 KiB HLT/JME
  • DQMHistoSizes: changed ( 12434.0 ): -17513.427 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 12434.0 ): -10390.469 KiB HLT/SiStrip
  • DQMHistoSizes: changed ( 12434.0 ): -10237.354 KiB HLT/HCAL
  • DQMHistoSizes: changed ( 12434.0 ): -10124.201 KiB HLT/BTV
  • DQMHistoSizes: changed ( 12434.0 ): -10043.763 KiB HLT/EXO
  • DQMHistoSizes: changed ( 12434.0 ): -9232.246 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 12434.0 ): -9053.111 KiB HLT/Muon
  • DQMHistoSizes: changed ( 12434.0 ): -8697.605 KiB HLT/Pixel
  • DQMHistoSizes: changed ( 12434.0 ): -5317.474 KiB HLT/SUSYBSM
  • DQMHistoSizes: changed ( 12434.0 ): ...
  • Checked 187 log files, 146 edm output root files, 45 DQM output files
  • TriggerResults: found differences in 1 / 43 workflows

@mmusich
Copy link
Contributor

mmusich commented Feb 26, 2024

+hlt

  • first step towards removal of the 2023v12 frozen HLT table from 14.1.X (to be replaced with the first 2024 menu when available).
  • changes in the wf 12434.0 (see DQM bin-by-bin comparison) are understood as due to the fact that now (when combining this with PR Updates for 2024 Wfs (PR Testing, IBs, Patatrack, inputs) #44075) this is the last 2023 MC workflow run in the limited matrix, and in 2023 workflows we now run the Fake menu, hence no HLT plots nor persistency of HLT decisions.

@mmusich
Copy link
Contributor

mmusich commented Feb 26, 2024

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 can you have a look and sign (if you're happy)?

@AdrianoDee
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44075

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bd29ce3 into cms-sw:master Feb 26, 2024
11 checks passed
@mmusich mmusich deleted the HLTrelva2023ToFake2141X branch February 26, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants