-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix on muon_mvaID in NanoAOD #43976
Fix on muon_mvaID in NanoAOD #43976
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43976/38884
|
A new Pull Request was created by @cramonal for master. It involves the following packages:
@vlimant, @hqucms, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -164,12 +162,11 @@ | |||
softId = Var("passed('SoftCutBasedId')",bool,doc="soft cut-based ID"), | |||
softMvaId = Var("passed('SoftMvaId')",bool,doc="soft MVA ID"), | |||
softMva = Var("softMvaValue()",float,doc="soft MVA ID score",precision=6), | |||
softMvaRun3 = Var("softMvaRun3Value()",float,doc="soft MVA Run3 ID score",precision=6), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the removal of softMvaRun3
intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed it was not. This is fixed in the new commit
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43976/38903
|
enable nano |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a998d6/37567/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 |
please test |
please test |
type muon |
please abort |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a998d6/37794/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
I lost track of the backport PR, do we have one ? |
+1 |
PR description:
This PR is a fix to the previous implementation of the muon MVA ID in nanoAOD [1].
In this fix the score of the MVA ID (mvaIDMuon) is computed on the fly when producing the nanoAOD. In the current implementation this is read from the miniAOD which has a non final version of the training. With this fix we make sure the training that has been published in CMS-PAS-MUO-22-001 enters the following nanoAOD versions.
Note: the WP variables (mvaIDMuon_wpTight and mvaIDMuon_wpMedium ) were computed in nanoAOD already.
[1] #41903
PR validation:
[2] [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/18E0AF9F-BA7F-E011-AC1C-001D09F24259.root
[b] Input file root://xrootd-cms.infn.it//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/18E0AF9F-BA7F-E011-AC1C-001D09F24259.root could not be opened.
[c] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/18E0AF9F-BA7F-E011-AC1C-001D09F24259.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
[d] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/18E0AF9F-BA7F-E011-AC1C-001D09F24259.root?tried=+1213llrxrd-redir.in2p3.fr,&xrdcl.requuid=43b88d64-2f45-401b-b96d-41b1aa1d7c12
[e] Problematic data server: cms-xrd-global.cern.ch:1094
[f] Disabled source: cms-xrd-global.cern.ch:1094
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
We would like to have this backported to 14_0_X, so this enters in NanoAODv14.