Fix on muon_mvaID in NanoAOD #43976

cramonal · 2024-02-15T10:44:47Z

PR description:

This PR is a fix to the previous implementation of the muon MVA ID in nanoAOD [1].

In this fix the score of the MVA ID (mvaIDMuon) is computed on the fly when producing the nanoAOD. In the current implementation this is read from the miniAOD which has a non final version of the training. With this fix we make sure the training that has been published in CMS-PAS-MUO-22-001 enters the following nanoAOD versions.

Note: the WP variables (mvaIDMuon_wpTight and mvaIDMuon_wpMedium ) were computed in nanoAOD already.

[1] #41903

PR validation:

The code changes have passed most of the standard runTheMatrix test workflows. There was only one failure when running 1000.0_RunMinBias2011A step 3. The error [2] seems unrealted with the changes in this PR.
We execute the basic tests suggested in the CMSSW PR instructions.

[2] [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/18E0AF9F-BA7F-E011-AC1C-001D09F24259.root
[b] Input file root://xrootd-cms.infn.it//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/18E0AF9F-BA7F-E011-AC1C-001D09F24259.root could not be opened.
[c] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/18E0AF9F-BA7F-E011-AC1C-001D09F24259.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
[d] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/18E0AF9F-BA7F-E011-AC1C-001D09F24259.root?tried=+1213llrxrd-redir.in2p3.fr,&xrdcl.requuid=43b88d64-2f45-401b-b96d-41b1aa1d7c12
[e] Problematic data server: cms-xrd-global.cern.ch:1094
[f] Disabled source: cms-xrd-global.cern.ch:1094

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

We would like to have this backported to 14_0_X, so this enters in NanoAODv14.

cmsbuild · 2024-02-15T10:45:13Z

cms-bot internal usage

cmsbuild · 2024-02-15T10:50:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43976/38884

This PR adds an extra 16KB to repository

cmsbuild · 2024-02-15T10:51:15Z

A new Pull Request was created by @cramonal for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@vlimant, @hqucms, @cmsbuild can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

hqucms · 2024-02-15T17:00:22Z

PhysicsTools/NanoAOD/python/muons_cff.py

@@ -164,12 +162,11 @@
        softId = Var("passed('SoftCutBasedId')",bool,doc="soft cut-based ID"),
        softMvaId = Var("passed('SoftMvaId')",bool,doc="soft MVA ID"),
        softMva = Var("softMvaValue()",float,doc="soft MVA ID score",precision=6),
-        softMvaRun3 = Var("softMvaRun3Value()",float,doc="soft MVA Run3 ID score",precision=6),


Is the removal of softMvaRun3 intended?

Indeed it was not. This is fixed in the new commit

cmsbuild · 2024-02-15T18:25:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43976/38903

This PR adds an extra 16KB to repository

cmsbuild · 2024-02-15T18:25:56Z

Pull request #43976 was updated. @vlimant, @cmsbuild, @hqucms can you please check and sign again.

vlimant · 2024-02-20T08:48:35Z

enable nano

vlimant · 2024-02-20T08:48:40Z

please test

cmsbuild · 2024-02-20T11:52:04Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a998d6/37567/summary.html
COMMIT: a921262
CMSSW: CMSSW_14_1_X_2024-02-19-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43976/37567/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 10 lines from the logs
Reco comparison results: 56 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248389
DQMHistoTests: Total failures: 1196
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3247171
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16430
DQMHistoTests: Total failures: 17
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16413
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.551	2.551	0.000 ( +0.0% )	5.27	5.22	+0.9%	2.118	2.216
2500.001	2.700	2.700	0.000 ( +0.0% )	4.73	4.69	+0.7%	2.528	2.625
2500.002	2.641	2.641	0.000 ( +0.0% )	4.89	4.89	+0.0%	2.530	2.626
2500.01	1.322	1.322	0.000 ( +0.0% )	9.53	9.69	-1.7%	2.206	2.270
2500.011	1.745	1.745	0.000 ( +0.0% )	5.14	5.26	-2.3%	2.369	2.530
2500.012	1.586	1.586	0.000 ( +0.0% )	7.34	7.51	-2.3%	2.266	2.411
2500.1	2.194	2.194	0.000 ( +0.0% )	5.31	5.25	+1.1%	1.957	2.059
2500.2	2.310	2.310	0.000 ( +0.0% )	6.06	6.04	+0.2%	1.866	1.973
2500.21	1.186	1.185	0.001 ( +0.0% )	4.36	4.33	+0.6%	2.160	2.250
2500.211	1.550	1.549	0.001 ( +0.0% )	3.80	3.76	+0.9%	2.218	2.333
2500.3	2.061	2.060	0.001 ( +0.0% )	12.87	12.66	+1.6%	1.870	1.951
2500.31	1.258	1.257	0.001 ( +0.1% )	20.15	20.16	-0.1%	2.276	2.349
2500.311	1.647	1.646	0.001 ( +0.0% )	12.48	12.32	+1.3%	2.313	2.412
2500.312	7.159	7.159	0.000 ( +0.0% )	1.39	1.39	+0.5%	1.679	1.681
2500.313	1.564	1.564	0.000 ( +0.0% )	7.13	6.70	+6.4%	1.034	1.032
2500.4	2.061	2.060	0.001 ( +0.0% )	12.75	12.66	+0.7%	1.875	1.954
2500.5	19.575	19.575	0.000 ( +0.0% )	1.15	1.17	-1.8%	1.085	1.343

vlimant · 2024-02-20T13:43:56Z

+1

cmsbuild · 2024-02-26T08:45:13Z

Pull request #43976 was updated. @cmsbuild, @hqucms, @vlimant can you please check and sign again.

vlimant · 2024-02-26T10:31:33Z

please test

vlimant · 2024-02-27T10:11:15Z

please test

vlimant · 2024-02-27T10:12:38Z

type muon

vlimant · 2024-02-28T15:32:43Z

please abort

vlimant · 2024-02-28T15:33:11Z

please test

cmsbuild · 2024-02-28T18:16:47Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a998d6/37794/summary.html
COMMIT: 0f54c7e
CMSSW: CMSSW_14_1_X_2024-02-28-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43976/37794/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 46 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3011576
DQMHistoTests: Total failures: 16
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3011538
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16430
DQMHistoTests: Total failures: 17
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16413
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 40 log files, 20 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.551	2.551	0.000 ( +0.0% )	5.31	5.05	+5.0%	2.222	2.217
2500.001	2.700	2.700	0.000 ( +0.0% )	4.66	4.77	-2.3%	2.656	2.659
2500.002	2.641	2.641	0.000 ( +0.0% )	4.88	4.89	-0.1%	2.652	2.637
2500.01	1.322	1.322	0.000 ( +0.0% )	9.65	9.88	-2.3%	2.320	2.338
2500.011	1.745	1.745	0.000 ( +0.0% )	5.18	5.27	-1.7%	2.427	2.528
2500.012	1.586	1.586	0.000 ( +0.0% )	7.32	7.59	-3.5%	2.339	2.375
2500.1	2.194	2.194	0.000 ( +0.0% )	5.30	5.32	-0.3%	2.059	2.058
2500.2	2.310	2.310	0.000 ( +0.0% )	6.15	6.05	+1.6%	1.975	1.971
2500.21	1.186	1.185	0.001 ( +0.0% )	4.37	4.35	+0.6%	2.260	2.268
2500.211	1.550	1.549	0.001 ( +0.0% )	3.82	3.78	+1.1%	2.337	2.345
2500.3	2.061	2.060	0.001 ( +0.0% )	12.61	12.65	-0.3%	1.964	1.953
2500.31	1.258	1.258	0.000 ( +0.0% )	20.25	20.32	-0.4%	2.356	2.333
2500.311	1.645	1.644	0.001 ( +0.0% )	13.73	13.57	+1.2%	2.432	2.435
2500.312	7.159	7.159	0.000 ( +0.0% )	1.46	1.37	+6.6%	1.687	1.681
2500.313	1.564	1.564	0.000 ( +0.0% )	6.81	6.92	-1.6%	1.045	1.034
2500.314	1.158	1.157	0.001 ( +0.0% )	14.87	13.89	+7.1%	2.170	2.172
2500.4	2.061	2.060	0.001 ( +0.0% )	12.56	12.57	-0.1%	1.855	1.953
2500.401	1.818	1.817	0.000 ( +0.0% )	10.81	10.87	-0.5%	1.799	1.811
2500.5	19.575	19.575	0.000 ( +0.0% )	1.22	1.27	-3.4%	1.320	1.349

vlimant · 2024-02-29T22:33:31Z

+1

cmsbuild · 2024-02-29T22:33:53Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

vlimant · 2024-02-29T22:35:07Z

I lost track of the backport PR, do we have one ?

antoniovilela · 2024-03-01T11:18:45Z

+1

cmsbuild added this to the CMSSW_14_1_X milestone Feb 15, 2024

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Feb 15, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 15, 2024

hqucms reviewed Feb 15, 2024

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 15, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 15, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 20, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 20, 2024

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Feb 20, 2024

cmsbuild added the code-checks-approved label Feb 26, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 26, 2024

grzanka mentioned this pull request Feb 26, 2024

[PPS] Added gtStage2DigisAlCaRecoProducer to ALCARECOPRODUCER #44044

Merged

cmsbuild added the muon label Feb 27, 2024

cmsbuild added tests-pending and removed tests-started labels Feb 28, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 28, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 28, 2024

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Feb 29, 2024

cmsbuild added orp-approved and removed orp-pending labels Mar 1, 2024

cmsbuild merged commit 0093705 into cms-sw:master Mar 1, 2024
13 checks passed

cramonal mentioned this pull request Mar 4, 2024

Fix on mvaID for muons (backport) #44294

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix on muon_mvaID in NanoAOD #43976

Fix on muon_mvaID in NanoAOD #43976

cramonal commented Feb 15, 2024

cmsbuild commented Feb 15, 2024 •

edited

Loading

cmsbuild commented Feb 15, 2024

cmsbuild commented Feb 15, 2024

hqucms Feb 15, 2024

cramonal Feb 15, 2024

cmsbuild commented Feb 15, 2024

cmsbuild commented Feb 15, 2024

vlimant commented Feb 20, 2024

vlimant commented Feb 20, 2024

cmsbuild commented Feb 20, 2024

vlimant commented Feb 20, 2024

cmsbuild commented Feb 26, 2024

vlimant commented Feb 26, 2024

vlimant commented Feb 27, 2024

vlimant commented Feb 27, 2024

vlimant commented Feb 28, 2024

vlimant commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

vlimant commented Feb 29, 2024

cmsbuild commented Feb 29, 2024

vlimant commented Feb 29, 2024

antoniovilela commented Mar 1, 2024

Fix on muon_mvaID in NanoAOD #43976

Fix on muon_mvaID in NanoAOD #43976

Conversation

cramonal commented Feb 15, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Feb 15, 2024 • edited Loading

cmsbuild commented Feb 15, 2024

cmsbuild commented Feb 15, 2024

hqucms Feb 15, 2024

Choose a reason for hiding this comment

cramonal Feb 15, 2024

Choose a reason for hiding this comment

cmsbuild commented Feb 15, 2024

cmsbuild commented Feb 15, 2024

vlimant commented Feb 20, 2024

vlimant commented Feb 20, 2024

cmsbuild commented Feb 20, 2024

Comparison Summary

NANO Comparison Summary

vlimant commented Feb 20, 2024

cmsbuild commented Feb 26, 2024

vlimant commented Feb 26, 2024

vlimant commented Feb 27, 2024

vlimant commented Feb 27, 2024

vlimant commented Feb 28, 2024

vlimant commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

Comparison Summary

NANO Comparison Summary

vlimant commented Feb 29, 2024

cmsbuild commented Feb 29, 2024

vlimant commented Feb 29, 2024

antoniovilela commented Mar 1, 2024

cmsbuild commented Feb 15, 2024 •

edited

Loading