Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2024 FastSim workflow #46068

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Add 2024 FastSim workflow #46068

merged 3 commits into from
Oct 2, 2024

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Sep 19, 2024

PR description:

Add 2024 FastSim workflow. This PR used PU dataset from 2023FSPU first, and will update when 2024FSPU is available.

PR validation:

Test with workflow 16434.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backport to the release of 2024 MC

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #46068 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

@srimanob
Copy link
Contributor Author

Hi @AdrianoDee

In #44075, you add 2024 FastSim workflows (14434.0, 14634.0, 14440.303), but those ID were not for FastSim. Is it just a bug in that PR?

@srimanob
Copy link
Contributor Author

test parameters:

  • workflows = 16434.0, 16634.0, 16440.303
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@cmsbuild
Copy link
Contributor

Pull request #46068 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@srimanob
Copy link
Contributor Author

+Upgrade

All new 2024 FastSim workflow run fine.

FYI @sbein @kpedro88

@srimanob
Copy link
Contributor Author

srimanob commented Oct 2, 2024

@cmsbuild please test

@srimanob
Copy link
Contributor Author

srimanob commented Oct 2, 2024

Kindly ping @cms-sw/pdmv-l2

@@ -4377,6 +4377,7 @@ def gen2024HiMix(fragment,howMuch):
defaultDataSets['2024']='CMSSW_14_0_0_pre3-140X_mcRun3_2024_realistic_v1_STD_2024_noPU-v'
defaultDataSets['2024HLTOnDigi']='CMSSW_14_0_0_pre3-140X_mcRun3_2024_realistic_v1_STD_2024_noPU-v'
defaultDataSets["2024SimOnGen"] = 'CMSSW_14_0_0_pre3-140X_mcRun3_2024_realistic_v1_STD_2024_noPU-v'
defaultDataSets['2024FS']='CMSSW_13_0_11-130X_mcRun3_2023_realistic_withEarly2023BS_v1_FastSim-v' #To replace with new dataset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @srimanob if it is useful to have a new production let us know on JIRA and we can organize this :-)

@AdrianoDee
Copy link
Contributor

+pdmv
(failures un-related)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21ca59/41883/summary.html
COMMIT: 0c0a407
CMSSW: CMSSW_14_2_X_2024-10-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46068/41883/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@srimanob
Copy link
Contributor Author

srimanob commented Oct 2, 2024

Failure does not relate to this PR.

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7d1afdf into cms-sw:master Oct 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants